AWS S3 SDK always tries to load log4net assembly even if logging is disabled or set to output to console

[madhub]

Description

AWS S3 SDK always tries to load log4net assembly even if logging is disabled or set to output to console

We have application where we provide Assembly Resolver to resolve plugin assemblies, on every application launch our resolver is called to load log4net assembly even if logging is disabled or set to output to console.

Expectation : If logging is disabled or set to output to console , library should try load log4net assembly

Reproduction Steps

public class AWSSample
    {
        private const string DllExtension = ".dll";

        static void Main(string[] args)
        {
            // Assembly Resolver to load Plugin assemblies
            AssemblyLoadContext.Default.Resolving += Default_Resolving;
            string accessKey = "minioadmin";
            string secretKey = "minioadmin"; // do not store secret key hardcoded in your production source code!

            // Setting LoggingOptions.None also tries to load log4net
            AWSConfigs.Logging = LoggingOptions.Console;

            var config = new AmazonS3Config
            {
                RegionEndpoint = RegionEndpoint.USEast1, 
                ServiceURL = "http://localhost:9000", 
                ForcePathStyle = true,

                // disabling logging
                DisableLogging = true,

                Timeout = TimeSpan.FromSeconds(4)

            };
            var amazonS3Client = new AmazonS3Client(accessKey, secretKey, config);
            TransferUtility transferUtility = new TransferUtility(amazonS3Client);
            try
            {
                transferUtility.UploadDirectory(@"C:\Data\docs", "demo");
            }
            catch (Exception exp)
            {
                Console.WriteLine(exp.ToString());
            }

        }

        /// <summary>
        /// Assembly Resolver to load Plugin assemblies
        /// </summary>
        /// <param name="context"></param>
        /// <param name="arg2"></param>
        /// <returns></returns>
        private static System.Reflection.Assembly Default_Resolving(AssemblyLoadContext context, System.Reflection.AssemblyName arg2)
        {
            var path = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, arg2.Name + DllExtension);
            try
            {
                if (File.Exists(path))
                {
                    return context.LoadFromAssemblyPath(path);
                }

                Console.WriteLine($"Unable to locate {arg2.Name} at {path}");
            }
            catch (Exception e)
            {
                Console.WriteLine($"Unable to locate {arg2.Name} at {path}", e);
            }
            
            return null;
        }
    }

Logs

Environment

• SDK Version: AWSSDK.S3 3.3.111.23
• Package Version:AWSSDK.S3 3.3.111.23
• OS Info: Windows 10
• Build Environment Terminal dotnet
• Targeted .NET Platform: .NET Core 3.1

Resolution

• 👋 I can/would-like-to implement a fix for this problem myself

---

This is a 🐛 bug-report

[github-actions]

We have noticed this issue has not received attention in 1 year. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue.

[madhub]

Any update on this issue, This needs to be fixed.

[normj]

The internal reflection for log4net has been removed in the upcoming V4 of the SDK. In V4 connecting the SDK's logging to a logging framework is done by including an adaptor package. Check out the logging section in the V4 tracker issue. #3362

[github-actions]

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.