Manual Sweep of S3 for protocol test work #3675
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since s3 is handcoded, the protocol test changes we made didn't propagate to S3. S3 was mostly in line with the protocol tests. There were some very minor changes such as adding missing xml namespaces and prefixes.
I also removed the
IXmlUnmarshaller<JsonUnmarshallerContext>
implementation for the structure unmarshallers since the unmarshallers don't need to implement both interfaces anymore.Motivation and Context
Updates S3 to be inline with other services.
Testing
DRY_RUN-0cbfaf75-64e3-4948-9d69-ec49e21f9d54
Screenshots (if appropriate)
Types of changes
Checklist
License