Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Sweep of S3 for protocol test work #3675

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

peterrsongg
Copy link
Contributor

@peterrsongg peterrsongg commented Feb 26, 2025

Description

Since s3 is handcoded, the protocol test changes we made didn't propagate to S3. S3 was mostly in line with the protocol tests. There were some very minor changes such as adding missing xml namespaces and prefixes.

I also removed the IXmlUnmarshaller<JsonUnmarshallerContext> implementation for the structure unmarshallers since the unmarshallers don't need to implement both interfaces anymore.

Motivation and Context

Updates S3 to be inline with other services.

Testing

DRY_RUN-0cbfaf75-64e3-4948-9d69-ec49e21f9d54

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@dscpinheiro dscpinheiro merged commit 66486a1 into v4-development Feb 28, 2025
2 checks passed
@dscpinheiro dscpinheiro deleted the petesong/s3-protocol-manual-sweep branch February 28, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants