-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DateOnly / TimeOnly in DynamoDBContext #3677
Support DateOnly / TimeOnly in DynamoDBContext #3677
Conversation
I have added unit tests which verify added changes. I have temporary changed csproj (and commented out lots of non-compiling tests) to make sure that tests are correct. Not sure if anything could be done in scope of this PR... |
The changes look good. Can you add a change log file to the PR so I can run it through our internal build system and it will update the change log. To add a change log file add a file a
|
Done, thanks for help! |
Thanks for adding the file. I have submitted the PR through the internal build system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Internal build was successful
Thanks for the PR, it'll be included in the next V4 preview. For your test comment, after V4 goes GA I'd like to revisit our test projects to target all frameworks we support, but this is a (much) larger effort that's definitely out of scope for this PR. |
Description
Added DateOnly and TimeOnly converters (for both V1 and V2 schemas).
Motivation and Context
Fixes #3673
Testing
Screenshots (if appropriate)
Types of changes
Checklist
License