Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DateOnly / TimeOnly in DynamoDBContext #3677

Merged
merged 4 commits into from
Mar 5, 2025

Conversation

Dreamescaper
Copy link
Contributor

Description

Added DateOnly and TimeOnly converters (for both V1 and V2 schemas).

Motivation and Context

Fixes #3673

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@Dreamescaper
Copy link
Contributor Author

I have added unit tests which verify added changes.
However, UnitTests project is never executed for net8.0 framework.

I have temporary changed csproj (and commented out lots of non-compiling tests) to make sure that tests are correct.
But at this point they will not be executed automatically.

Not sure if anything could be done in scope of this PR...

@normj normj self-requested a review February 27, 2025 22:04
@normj
Copy link
Member

normj commented Feb 28, 2025

The changes look good. Can you add a change log file to the PR so I can run it through our internal build system and it will update the change log. To add a change log file add a file a <repo-root>/generator/.DevConfigs/<random-guid>/json with the following content.

{
    "services": [
        {
            "serviceName": "DynamoDBv2",
            "type": "patch",
            "changeLogMessages": [
                "Add Support for DateOnly and TimeOnly in DynamoDB high level libraries. This support is available in .NET 8 and above."
            ]
        }
    ]
}

@Dreamescaper
Copy link
Contributor Author

Dreamescaper commented Mar 2, 2025

Done, thanks for help!

@normj
Copy link
Member

normj commented Mar 2, 2025

Thanks for adding the file. I have submitted the PR through the internal build system.

Copy link
Member

@normj normj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal build was successful

@dscpinheiro
Copy link
Contributor

Thanks for the PR, it'll be included in the next V4 preview.

For your test comment, after V4 goes GA I'd like to revisit our test projects to target all frameworks we support, but this is a (much) larger effort that's definitely out of scope for this PR.

@dscpinheiro dscpinheiro merged commit 5d0018d into aws:v4-development Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants