Updated credential providers to provide Async version for generating credentials. #3681

ashishdhingra · 2025-02-28T19:14:16Z

Description

Updated credential providers to provide Async version for generating credentials.

NOTE:
Async methods don't have parameter for CancellationToken since the GetCredentialsAsync() doesn't have it.

Motivation and Context

Issue #3626
Existing customer PR #3627

Testing

Added test cases for TestAssumeRoleAWSCredentialsAsyncGet and TestEC2InstanceMetadataSecureCredentialsSuccessAsync.
Dry-run DRY_RUN-e95a1656-57b3-44db-88d5-d14060e1e1db completed successfully.

References for SAML Federation:

How do I set up AD FS on an Amazon EC2 Windows instance to work with federation for an Amazon Cognito user pool?
Enabling Federation to AWS Using Windows Active Directory, ADFS, and SAML 2.0
This requires reserving Elastic IP address, create public hosted zone and registering domain name.

Federated SAML credentials cannot be tested via shared credentials file. I was able to step through the code and hack way around. The problem is that EndpointDiscoveryHandler.ProcessEndpointDiscovery() uses non-async version to get credentials.

Testing Customer's scenario:

Create a new role named TestEC2ReadOnlyRole with AmazonEC2ReadOnlyAccess permission policy and below trust relationship with the account:

{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Principal": {
                "AWS": "arn:aws:iam::<<ACCOUNT-ID>>:root"
            },
            "Action": "sts:AssumeRole",
            "Condition": {}
        }
    ]
}

In ~/.aws/config file, setup below profile:

[default]
region = us-east-2
output = json

[profile testassumerole]
source_profile = default
role_arn = arn:aws:iam::<<ACCOUNT-ID>>:role/TestEC2ReadOnlyRole

The main credentials for default profile are configured in ~/.aws/credentials.

While debugging via Visual Studio, set AWS_PROFILE environment variable to testassumerole.

While the async path for ICoreAmazonSTS.CredentialsFromAssumeRoleAuthenticationAsync() is triggered in V4 branch for this PR, but below are my observations which highlight that sync path is triggered at some point. Comparison between V3 and V4 stack trace is also mentioned.

@normj / @dscpinheiro Prior to implementation of SRA, SDK used CredentialsRetriever (refer stack trace in customer's issue #3626). It emitted InvokeAsync() versions. Is there an equivalent in SRA world? Now EndpointDiscoveryHandler always uses sync version at EndpointDiscoveryHandler.ProcessEndpointDiscovery(). We have removed CredentialsRetriever in V4 in commit. Please suggest if async invocation for retrieving credentials is no longer possible in V4!

V3 Call stack:
While debugging it worked fine.

>	AWSSDK.Core.dll!Amazon.Runtime.RefreshingAWSCredentials.GenerateNewCredentialsAsync() Line 273	C#
 	AWSSDK.Core.dll!Amazon.Runtime.RefreshingAWSCredentials.GetCredentialsAsync() Line 154	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.CredentialsRetriever.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 99	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 165	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.RetryHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 135	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 165	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.CompressionHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 57	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 165	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.CallbackHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 61	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 165	C#
 	AWSSDK.EC2.dll!Amazon.EC2.Internal.AmazonEC2PostMarshallHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 57	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 165	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.BaseEndpointResolver.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 43	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 165	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.Marshaller.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 56	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 165	C#
 	AWSSDK.EC2.dll!Amazon.EC2.Internal.AmazonEC2PreMarshallHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 80	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 165	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.CallbackHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 61	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 165	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.ErrorCallbackHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 53	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 165	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.MetricsHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 94	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.RuntimePipeline.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 152	C#
 	AWSSDK.Core.dll!Amazon.Runtime.AmazonServiceClient.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.AmazonWebServiceRequest request, Amazon.Runtime.Internal.InvokeOptionsBase options, System.Threading.CancellationToken cancellationToken) Line 278	C#
 	AWSSDK.EC2.dll!Amazon.EC2.AmazonEC2Client.DescribeTagsAsync(Amazon.EC2.Model.DescribeTagsRequest request, System.Threading.CancellationToken cancellationToken) Line 16218	C#
 	AWSSDK.EC2.dll!Amazon.EC2.AmazonEC2Client.DescribeTagsAsync(System.Threading.CancellationToken cancellationToken) Line 16180	C#
 	V4Test.dll!Program.<Main>$(string[] args) Line 7	C#

V4 Call stack:

>	AWSSDK.Core.dll!Amazon.Runtime.AssumeRoleAWSCredentials.GenerateNewCredentials() Line 105	C#
 	AWSSDK.Core.dll!Amazon.Runtime.RefreshingAWSCredentials.GetCredentials.__GenerateCredentialsAndUpdateState|11_0() Line 166	C#
 	AWSSDK.Core.dll!Amazon.Runtime.RefreshingAWSCredentials.GetCredentials() Line 150	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.EndpointDiscoveryHandler.ProcessEndpointDiscovery(Amazon.Runtime.IRequestContext requestContext, bool evictCacheKey, System.Uri evictUri) Line 136	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.EndpointDiscoveryHandler.DiscoverEndpoints(Amazon.Runtime.IRequestContext requestContext, bool evictCacheKey) Line 112	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.EndpointDiscoveryHandler.PreInvoke(Amazon.Runtime.IExecutionContext executionContext) Line 101	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.EndpointDiscoveryHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 72	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.ChecksumHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 52	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.RetryHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 135	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.CompressionHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 56	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.CallbackHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 61	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.EC2.dll!Amazon.EC2.Internal.AmazonEC2PostMarshallHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 57	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.BaseEndpointResolver.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 43	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.BaseAuthResolverHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 47	C#
 	[Async Call Stack]	
 	[Async] AWSSDK.Core.dll!Amazon.Runtime.Internal.CallbackHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 61	C#
 	[Async] AWSSDK.Core.dll!Amazon.Runtime.Internal.ErrorCallbackHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 53	C#
 	[Async] AWSSDK.Core.dll!Amazon.Runtime.Internal.MetricsHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 93	C#
 	[Async] V4Test.dll!Program.<Main>$(string[] args) Line 7	C#

It ultimately calls async version while invoking Signer to sign the request:

>	AWSSDK.Core.dll!Amazon.Runtime.RefreshingAWSCredentials.GetCredentialsAsync() Line 183	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.Signer.SignRequestAsync(Amazon.Runtime.IRequestContext requestContext) Line 158	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.Signer.PreInvokeAsync(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.Signer.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 57	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.EndpointDiscoveryHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 76	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.ChecksumHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 52	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.RetryHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 135	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.CompressionHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 56	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.CallbackHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 61	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.EC2.dll!Amazon.EC2.Internal.AmazonEC2PostMarshallHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 57	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.BaseEndpointResolver.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 43	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.BaseAuthResolverHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 47	C#

But looks like at some point(s) we make sync calls. And it might fail at the previous sync stack trace while assuming role, on platforms like Android which don't support sync calls (per customer's issue).

Screenshots (if appropriate)

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

My code follows the code style of this project
My change requires a change to the documentation
I have updated the documentation accordingly
I have read the README document
I have added tests to cover my changes
All new and existing tests passed

License

I confirm that this pull request can be released under the Apache 2 license

dscpinheiro

I took an initial pass but as discussed offline there's a lot of code that had to be duplicated and I'm not sure it's the best approach.

For the question in the description, we removed the credential retriever pipeline handler and the signers now retrieve credentials themselves. The async method in the signer just invokes the sync version:

aws-sdk-net/sdk/src/Core/Amazon.Runtime/Internal/Auth/AbstractAWSSigner.cs

Lines 115 to 130 in 9d4fea3

    
                   public virtual System.Threading.Tasks.Task SignAsync( 
        
                       IRequest request,  
        
                       IClientConfig clientConfig, 
        
                       RequestMetrics metrics, 
        
                       BaseIdentity identity, 
        
                       CancellationToken token = default) 
        
                   { 
        
                       Sign(request, clientConfig, metrics, identity); 
        
           #if NETSTANDARD 
        
                       return Task.CompletedTask; 
        
           #else 
        
                       return Task.FromResult(0); 
        
           #endif 
        
                   } 
        
           #endif

dscpinheiro · 2025-03-06T14:23:38Z

generator/.DevConfigs/9fa1d027-8266-430e-b4c0-a541eb733f8e.json

+            "Updated credential providers to provide Async version for generating credentials."
+        ],
+        "type": "patch",
+        "updateMinimum": false


It doesn't matter here for V4 since we ship all packages, but this should be true (it's rare that a change to Core won't require all services to be updated too).

dscpinheiro · 2025-03-06T14:27:32Z

sdk/src/Core/Amazon.Runtime/Credentials/AWSCredentials.cs

@@ -35,11 +35,9 @@ public abstract class AWSCredentials : BaseIdentity
        /// </summary>
        protected virtual void Validate() { }

-#if AWS_ASYNC_API


Why are we removing AWS_ASYNC_API? (By the way I think this constant is redundant since every target supports async but it's in a lot of other places too)

I removed it based on discussion with @normj since it is now redundant. And based on discussion, the current scope of removal was limited to credential providers.

dscpinheiro · 2025-03-06T14:28:57Z

sdk/test/NetStandard/IntegrationTests/IntegrationTests/CredentialsTests.cs

+
+        [Fact]
+        [Trait(TestBase.CategoryAttribute, "Credentials")]
+        public async Task TestAssumeRoleAWSCredentialsAsyncGet()


FYI This test doesn't run in our build system (it skips the RequiresIAMUser category that's applied to the parent class).

Thanks for letting me know. Do we have reasoning for excluding the test RequiresIAMUser category?

dscpinheiro · 2025-03-06T14:32:21Z

sdk/src/Core/Amazon.Runtime/Credentials/RefreshingAWSCredentials.cs

If you're updating this file I'm wondering if it makes sense to also fix #3613

Discussed this with @norm and looked at the backlog item. The issue needs investigation per backlog item on why preemptExpiryTime parameter is not used, and if we should be using it. It's the pending item and we should discuss about it.

ashishdhingra · 2025-03-06T17:10:04Z

I took an initial pass but as discussed offline there's a lot of code that had to be duplicated and I'm not sure it's the best approach.

For the question in the description, we removed the credential retriever pipeline handler and the signers now retrieve credentials themselves. The async method in the signer just invokes the sync version:

aws-sdk-net/sdk/src/Core/Amazon.Runtime/Internal/Auth/AbstractAWSSigner.cs

Lines 115 to 130 in 9d4fea3

public virtual System.Threading.Tasks.Task SignAsync(

IRequest request,

IClientConfig clientConfig,

RequestMetrics metrics,

BaseIdentity identity,

CancellationToken token = default)

{

Sign(request, clientConfig, metrics, identity);

#if NETSTANDARD

return Task.CompletedTask;

#else

return Task.FromResult(0);

#endif

}

#endif

@dscpinheiro Thanks for the review. I understand the signer will call Async version based on stack trace I shared earlier:

AWSSDK.Core.dll!Amazon.Runtime.RefreshingAWSCredentials.GetCredentialsAsync() Line 183	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.Signer.SignRequestAsync(Amazon.Runtime.IRequestContext requestContext) Line 158	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.Signer.PreInvokeAsync(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.Signer.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 57	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.EndpointDiscoveryHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 76	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.ChecksumHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 52	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#

I'm referring to sync call in below stack trace after AmazonEC2PostMarshallHandler.InvokeAsync():

AWSSDK.Core.dll!Amazon.Runtime.AssumeRoleAWSCredentials.GenerateNewCredentials() Line 105	C#
 	AWSSDK.Core.dll!Amazon.Runtime.RefreshingAWSCredentials.GetCredentials.__GenerateCredentialsAndUpdateState|11_0() Line 166	C#
 	AWSSDK.Core.dll!Amazon.Runtime.RefreshingAWSCredentials.GetCredentials() Line 150	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.EndpointDiscoveryHandler.ProcessEndpointDiscovery(Amazon.Runtime.IRequestContext requestContext, bool evictCacheKey, System.Uri evictUri) Line 136	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.EndpointDiscoveryHandler.DiscoverEndpoints(Amazon.Runtime.IRequestContext requestContext, bool evictCacheKey) Line 112	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.EndpointDiscoveryHandler.PreInvoke(Amazon.Runtime.IExecutionContext executionContext) Line 101	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.EndpointDiscoveryHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 72	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.ChecksumHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 52	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.RetryHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 135	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.CompressionHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 56	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.CallbackHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 61	C#
 	AWSSDK.Core.dll!Amazon.Runtime.Internal.PipelineHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 82	C#
 	AWSSDK.EC2.dll!Amazon.EC2.Internal.AmazonEC2PostMarshallHandler.InvokeAsync<Amazon.EC2.Model.DescribeTagsResponse>(Amazon.Runtime.IExecutionContext executionContext) Line 57	C#

EndpointDiscoveryHandler takes place of CredentialsRetriever in this flow and as part of SRA change, it was updated to make sync call. Please review.

…credentials.

…or getting credentials.

ashishdhingra · 2025-03-06T21:15:04Z

For the question in the description, we removed the credential retriever pipeline handler and the signers now retrieve credentials themselves. The async method in the signer just invokes the sync version:

aws-sdk-net/sdk/src/Core/Amazon.Runtime/Internal/Auth/AbstractAWSSigner.cs

Lines 115 to 130 in 9d4fea3

public virtual System.Threading.Tasks.Task SignAsync(

IRequest request,

IClientConfig clientConfig,

RequestMetrics metrics,

BaseIdentity identity,

CancellationToken token = default)

{

Sign(request, clientConfig, metrics, identity);

#if NETSTANDARD

return Task.CompletedTask;

#else

return Task.FromResult(0);

#endif

}

#endif

@dscpinheiro Thanks for the feedback. I had discussed this with @normj and fixed it in commit e5a45f5. Please review.

…s-AsyncVersions

ashishdhingra requested review from normj and dscpinheiro February 28, 2025 19:14

ashishdhingra marked this pull request as draft February 28, 2025 19:22

dscpinheiro added the v4 label Feb 28, 2025

mscottford mentioned this pull request Mar 3, 2025

Adds async methods for assuming roles #3627

Open

10 tasks

ashishdhingra force-pushed the user/ashdhin/V4-CredentialProviders-AsyncVersions branch 2 times, most recently from 997906f to 75f984d Compare March 4, 2025 21:16

ashishdhingra marked this pull request as ready for review March 4, 2025 21:27

ashishdhingra force-pushed the user/ashdhin/V4-CredentialProviders-AsyncVersions branch 2 times, most recently from c4612e8 to e90cbf2 Compare March 4, 2025 22:50

dscpinheiro reviewed Mar 6, 2025

View reviewed changes

ashishdhingra force-pushed the user/ashdhin/V4-CredentialProviders-AsyncVersions branch from e90cbf2 to 06a4959 Compare March 6, 2025 21:03

ashishdhingra added 2 commits March 6, 2025 13:08

Updated credential providers to provide Async version for generating …

685cb86

…credentials.

Updated EndpointDiscoveryHandler to use correct sync/async versions f…

e5a45f5

…or getting credentials.

ashishdhingra force-pushed the user/ashdhin/V4-CredentialProviders-AsyncVersions branch from 06a4959 to e5a45f5 Compare March 6, 2025 21:12

Merge branch 'v4-development' into user/ashdhin/V4-CredentialProvider…

93895bc

…s-AsyncVersions

ashishdhingra requested a review from dscpinheiro March 6, 2025 21:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated credential providers to provide Async version for generating credentials. #3681

Updated credential providers to provide Async version for generating credentials. #3681

ashishdhingra commented Feb 28, 2025 •

edited

Loading

dscpinheiro left a comment

dscpinheiro Mar 6, 2025 •

edited

Loading

ashishdhingra Mar 6, 2025

dscpinheiro Mar 6, 2025

ashishdhingra Mar 6, 2025

dscpinheiro Mar 6, 2025

ashishdhingra Mar 6, 2025

dscpinheiro Mar 6, 2025

ashishdhingra Mar 6, 2025

ashishdhingra commented Mar 6, 2025

ashishdhingra commented Mar 6, 2025

	public virtual System.Threading.Tasks.Task SignAsync(
	IRequest request,
	IClientConfig clientConfig,
	RequestMetrics metrics,
	BaseIdentity identity,
	CancellationToken token = default)
	{
	Sign(request, clientConfig, metrics, identity);
	#if NETSTANDARD
	return Task.CompletedTask;
	#else
	return Task.FromResult(0);
	#endif
	}
	#endif

Updated credential providers to provide Async version for generating credentials. #3681

Are you sure you want to change the base?

Updated credential providers to provide Async version for generating credentials. #3681

Conversation

ashishdhingra commented Feb 28, 2025 • edited Loading

Description

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

Checklist

License

dscpinheiro left a comment

Choose a reason for hiding this comment

dscpinheiro Mar 6, 2025 • edited Loading

Choose a reason for hiding this comment

ashishdhingra Mar 6, 2025

Choose a reason for hiding this comment

dscpinheiro Mar 6, 2025

Choose a reason for hiding this comment

ashishdhingra Mar 6, 2025

Choose a reason for hiding this comment

dscpinheiro Mar 6, 2025

Choose a reason for hiding this comment

ashishdhingra Mar 6, 2025

Choose a reason for hiding this comment

dscpinheiro Mar 6, 2025

Choose a reason for hiding this comment

ashishdhingra Mar 6, 2025

Choose a reason for hiding this comment

ashishdhingra commented Mar 6, 2025

ashishdhingra commented Mar 6, 2025

ashishdhingra commented Feb 28, 2025 •

edited

Loading

dscpinheiro Mar 6, 2025 •

edited

Loading