Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated credential providers to provide Async version for generating credentials. #3681

Open
wants to merge 5 commits into
base: v4-development
Choose a base branch
from
Prev Previous commit
Next Next commit
Merge branch 'v4-development' into user/ashdhin/V4-CredentialProvider…
…s-AsyncVersions
  • Loading branch information
ashishdhingra authored Mar 6, 2025
commit 93895bcd2239d08e75a0f6a7d787d4ee9d70d17f
Original file line number Diff line number Diff line change
@@ -64,28 +64,6 @@ protected static async Task<string> GetContentsAsync(Uri uri, IWebProxy proxy, D
}
}

[Obsolete("This method is not compatible with Native AOT builds. The GetObjectFromResponse overload using the generic parameter taking in a JsonSerializerContext should be used instead.")]
[RequiresUnreferencedCode("GetObjectFromResponse overload using the generic parameter taking in a JsonSerializerContext should be used instead.")]
protected static T GetObjectFromResponse<T>(Uri uri)
{
return GetObjectFromResponse<T>(uri, null, null);
}

[Obsolete("This method is not compatible with Native AOT builds. The GetObjectFromResponse overload using the generic parameter taking in a JsonSerializerContext should be used instead.")]
[RequiresUnreferencedCode("GetObjectFromResponse overload using the generic parameter taking in a JsonSerializerContext should be used instead.")]
protected static T GetObjectFromResponse<T>(Uri uri, IWebProxy proxy)
{
return GetObjectFromResponse<T>(uri, proxy, null);
}

[Obsolete("This method is not compatible with Native AOT builds. The GetObjectFromResponse overload using the generic parameter taking in a JsonSerializerContext should be used instead.")]
[RequiresUnreferencedCode("GetObjectFromResponse overload using the generic parameter taking in a JsonSerializerContext should be used instead.")]
protected static T GetObjectFromResponse<T>(Uri uri, IWebProxy proxy, Dictionary<string, string> headers)
{
string json = GetContents(uri, proxy, headers);
return JsonSerializer.Deserialize<T>(json);
}

protected static T GetObjectFromResponse<T, TC>(Uri uri, IWebProxy proxy, Dictionary<string, string> headers)
where TC :
#if NET8_0_OR_GREATER
You are viewing a condensed version of this merge commit. You can view the full changes here.