Remove the obsolete ReadWriteTimeout property from ClientConfig for non-.NET Framework targets #3683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…argets except .NET Framework 4.7.2
dscpinheiro
previously approved these changes
Mar 1, 2025
peterrsongg
approved these changes
Mar 3, 2025
dscpinheiro
dismissed
their stale review
Waiting to see if V3 sync will be performed first.
dscpinheiro
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
ReadWriteTimeoutproperty on ClientConfig is marked obsolete in for non .NET Framework targets because the property didn't do anything. In non .NET Framework targets timeouts are supposed to be handled by cancellation tokens.For V4 we are removing the
ReadWriteTimeoutentirely for non .NET Framework targets. This will avoid confusion of users accidently setting it and thinking it will do something.Testing
Dry Run: DRY_RUN-a29ac1c0-97f0-4fb0-9dd2-d9366fbc671e Successful