-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete custom service package code #3684
Remove obsolete custom service package code #3684
Conversation
@@ -367,6 +367,8 @@ public static string Interpolate(string template, Dictionary<string, object> ref | |||
/// </summary> | |||
public static string InterpolateJson(string json, Dictionary<string, object> refs) | |||
{ | |||
if (string.IsNullOrEmpty(json)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this change to avoid the SDK generating a lot of JsonException
s being thrown when an empty string is being sent in.
VPC_NAT | ||
}; | ||
|
||
private const string CLOUDFRONT_LOCATION_OF_AMI_FILE = "https://aws-sdk-configurations.amazonwebservices.com/stockamis.json"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I think we even have a canary that checks this file can be downloaded, we can turn that off as well.
Waiting to see if V3 sync will be performed first.
Description
This PR goes through the service packages except for S3 and drops most all code that is marked as obsolete. The main code that is left that is obsolete is the DynamoDB HLL code that was just marked as obsolete as part of V4.
Overall changes:
CloudFront
AmazonCloudFrontUtil
utility class. It was only available for .NET Framework and the methods were mostly redirects to other Core pieces of code. PR Mark code that has been deleted in V4 as obsolete in V3 #3685 for V3 marks the type as obsolete.DynamoDB:
DynamoDBContextTableNamePrefix
property. Users should callAWSConfigsDynamoDB.Context.TableNamePrefix
instead ofAWSConfigsDynamoDB.Context.DynamoDBContextTableNamePrefix
.EC2:
IoT
Lambda
InvokeAsync
deprecated method. I know we don't remove deprecated modeled operations but always felt this method having anAsync
suffix makes the Lambda client confusing with the supportedInvoke
method which we generate asInvokeAsync
for the async use case. The original deprecated method's name doesn't work well for .NET. Since it is deprecated there is no reason to keep it.SageMager
SecurityToken
Testing
Dry Run: DRY_RUN-ef79ca15-4cb5-494a-80f4-2085ece52132 Successful