Remove S3 code that was obsolete in V3 for V4. #3686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
changed the title
normj
force-pushed
the
normj/remove-s3-obsolete-code
branch
from
cb30b8b to
017945f
Compare
|
Thanks for removing the checksum related properties, I should've done that in the last V3 sync. But for |
The GetACL and PutACL obsoletes were left since they were only obsolete in V4.
normj
force-pushed
the
normj/remove-s3-obsolete-code
branch
from
cd03a3e to
e215f6d
Compare
|
I have reverted the removal of the |
peterrsongg
reviewed
Mar 4, 2025
| [DataRow("bucket", "key")] | ||
| [DataTestMethod] | ||
| [TestCategory("S3")] | ||
| public void RequiredUriParameterBucketForGetAcl(string bucket, string key) |
There was a problem hiding this comment.
Should we put these back because GetACL is still there now or did you remove these on purpose?
I guess the test itself isn't really doing anything significant
dscpinheiro
approved these changes
Mar 5, 2025
peterrsongg
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deleted all obsolete code in S3 package for V4. Initially I thought I would leave some in but given that we want to look at auto generating S3 at some point I figured it would be best to remove as much customization logic as possible.
The obsolete code I was most on the fence about deleting
Expiresproperty in favor ofExpiresString.GetAclandPutAclservice methods. We have created new gets and puts per object and bucket which map to the S3 model. I debated about keeping this obsolete code to give an easier migration but since this was the SDK moving closer to the model it seemed better for a future auto generation effort.Testing
Dry Run: DRY_RUN-bd4e3e24-9cd1-4569-a2b7-eb07c6ae51eb Successful