Remove obsolete IPRange property from EC2 #3687
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
requested changes
Mar 4, 2025
| @@ -38,7 +38,6 @@ public class AmazonEC2PreMarshallHandler : PipelineHandler | |||
| internal enum IpRangeValue | |||
| { | |||
| Invalid, | |||
| IpRanges, | |||
There was a problem hiding this comment.
Can't remove this whole enum since we only have one property now?
There was a problem hiding this comment.
good point removed.
| default: | ||
| break; | ||
| } | ||
| ipPermission.SelectIpV4RangeForMarshalling(ipPermission.Ipv4Ranges); |
There was a problem hiding this comment.
Seems like we should be able to refactor EC2 to not even need this method since we only have one property now.
There was a problem hiding this comment.
good catch, I removed a bunch of related code that that was accounting for the old IpRanges property.
peterrsongg
force-pushed
the
petesong/remove-legacy-ip-ranges
branch
from
a263a2b to
3eb4d46
Compare
normj
approved these changes
Mar 4, 2025
|
latest dry run for .net and ps passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes obsolete
IPRangeproperty from EC2Motivation and Context
Removing obsolete code.
Testing
.NET and PS5 dry run successful
dotnet build Id: 84223c46-0fd4-4390-a5e5-d579e29614a4
Screenshots (if appropriate)
Types of changes
Checklist
License