-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete IPRange property from EC2 #3687
base: v4-development
Are you sure you want to change the base?
Conversation
@@ -38,7 +38,6 @@ public class AmazonEC2PreMarshallHandler : PipelineHandler | |||
internal enum IpRangeValue | |||
{ | |||
Invalid, | |||
IpRanges, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't remove this whole enum since we only have one property now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point removed.
default: | ||
break; | ||
} | ||
ipPermission.SelectIpV4RangeForMarshalling(ipPermission.Ipv4Ranges); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we should be able to refactor EC2 to not even need this method since we only have one property now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, I removed a bunch of related code that that was accounting for the old IpRanges
property.
a263a2b
to
3eb4d46
Compare
latest dry run for .net and ps passed |
Description
Removes obsolete
IPRange
property from EC2Motivation and Context
Removing obsolete code.
Testing
.NET and PS5 dry run successful
dotnet build Id: 84223c46-0fd4-4390-a5e5-d579e29614a4
Screenshots (if appropriate)
Types of changes
Checklist
License