Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete IPRange property from EC2 #3687

Open
wants to merge 3 commits into
base: v4-development
Choose a base branch
from

Conversation

peterrsongg
Copy link
Contributor

@peterrsongg peterrsongg commented Mar 3, 2025

Description

Removes obsolete IPRange property from EC2

Motivation and Context

Removing obsolete code.

Testing

.NET and PS5 dry run successful
dotnet build Id: 84223c46-0fd4-4390-a5e5-d579e29614a4

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@dscpinheiro dscpinheiro added the v4 label Mar 3, 2025
@@ -38,7 +38,6 @@ public class AmazonEC2PreMarshallHandler : PipelineHandler
internal enum IpRangeValue
{
Invalid,
IpRanges,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't remove this whole enum since we only have one property now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point removed.

default:
break;
}
ipPermission.SelectIpV4RangeForMarshalling(ipPermission.Ipv4Ranges);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we should be able to refactor EC2 to not even need this method since we only have one property now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, I removed a bunch of related code that that was accounting for the old IpRanges property.

@peterrsongg peterrsongg force-pushed the petesong/remove-legacy-ip-ranges branch from a263a2b to 3eb4d46 Compare March 4, 2025 06:08
@AlexDaines AlexDaines requested a review from dscpinheiro March 4, 2025 18:32
@peterrsongg
Copy link
Contributor Author

latest dry run for .net and ps passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants