Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete IPRange property from EC2 #3687

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Remove obsolete IPRange property from EC2 #3687

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
570dc32
Remove obsolete IPRange property from EC2
peterrsongg Feb 28, 2025
c732b06
update comment on test
peterrsongg Mar 3, 2025
3eb4d46
Additional refactoring to remove unused code
peterrsongg Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update comment on test
  • Loading branch information
@peterrsongg
peterrsongg committed Mar 3, 2025
commit c732b069c8fb0397df2388c87a287265ee19d053
8 changes: 1 addition & 7 deletions sdk/test/Services/EC2/IntegrationTests/SecurityGroupTests.cs
View file
Original file line number Diff line number Diff line change
@@ -106,13 +106,7 @@ public static void Cleanup()
/// Describe operation is performed at the end of each test to ensure actual behavior matches with the expected output.
/// 1. A new CidrIp is added using Ipv4Ranges property and a AuthorizeSecurityGroupEgressRequest is made.
/// Validation is performed to check the updated values appears on Ipv4Ranges property.
/// 2. A new IpRange is added to Ipv4Ranges property and a AuthorizeSecurityGroupEgressRequest is made.
/// Validation is performed to check the updated values appear on both IpRanges and Ipv4Ranges property.
/// 3. Different values are set on both IpRanges and Ipv4Ranges and a AuthorizeSecurityGroupEgressRequest is made.
/// Validation is perfomed to ensure that an ArgumentExcpetions is returned.
/// 4. A UpdateSecurityGroupRuleDescriptionsEgressRequest is made using the deprecated IpRanges property on a CidrIp for which a description exists.
/// Validation is perfomed to ensure that the description is not lost.
/// 5. A RevokeSecurityGroupEgressRequest operation is perfomed to remove all the IpPermissions added to the security group.
/// 2. A RevokeSecurityGroupEgressRequest operation is perfomed to remove all the IpPermissions added to the security group.
/// </summary>
[TestMethod]
[TestCategory("EC2")]