Add RoadRunner integration #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mullermp
reviewed
Mar 6, 2025
benchmark.rake
Outdated
| require 'json' | ||
| require_relative 'roadrunner' | ||
|
|
||
| if File.exist?('benchmark_report.json') |
There was a problem hiding this comment.
Guard clauses make this more readable. If the file doesn't exist, print and exit, then the rest of the logic that follows does not need to be inside an if statement.
jterapin
reviewed
Mar 6, 2025
There was a problem hiding this comment.
Nice! Agree with Matt on seeing if we can streamline the benchmark tools. Good opportunity to clean up our dashboard too.
Also - there's some rubocop failures - run rubocop locally to see what they are. Also rubocop -A to autocorrect if it makes sense to do so.
richardwang1124
changed the title
mullermp
reviewed
Mar 10, 2025
jterapin
reviewed
Mar 11, 2025
mullermp
approved these changes
Mar 12, 2025
benchmark/gem.rb
Outdated
| module Benchmark | ||
| # Abstract base class for benchmarking an SDK Gem. | ||
| # Implementors must define the `gem_name`, `client_klass`, and the | ||
| # `operation_benchmarks` methods. | ||
| # rubocop:disable Metrics/ClassLength |
There was a problem hiding this comment.
For class length, the rubocop default is pretty low IMO. I'd just change it to 200 globally and you won't need this one.
jterapin
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Generates a RoadRunner compatible
results.jsonfor performance testing.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.