Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separte PersistKeysToAWSSystemsManager into two methods PersistKeysTo* and ProtectKeysWithKMS #25

Open
2 tasks
maulik-modi opened this issue Oct 18, 2020 · 1 comment
Labels
feature-request A feature should be added or improved. module/sys-mgr-ext p2 This is a standard priority issue

Comments

@maulik-modi
Copy link

maulik-modi commented Oct 18, 2020

Currently there is a single method saying - PersistKeysToAWSSystemsManager that takes two responsibilities

  1. persisting and
  2. protecting keys.

Describe the Feature

We want to use KMS Keys for data protection and use Redis for persistence(Production) vs using FileSystem for persistence(DEV)
Look at how Azure Key vault and Redis can be used together as both concerns are different
https://docs.microsoft.com/en-us/aspnet/core/security/data-protection/configuration/overview?view=aspnetcore-3.1 shows

  1. PersistKeysToAzureBlobStorage and
  2. ProtectKeysWithAzureKeyVault

Is your Feature Request related to a problem?

YES

Proposed Solution

Provide an extension point in package

Describe alternatives you've considered

Include KMS Client package only and implement data protection methods

Additional Context

Environment

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@maulik-modi maulik-modi added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 18, 2020
@ashishdhingra
Copy link
Contributor

Appears to be a useful design change and needs to be reviewed by team.

@ashishdhingra ashishdhingra added needs-review and removed needs-triage This issue or PR still needs to be triaged. labels Jan 20, 2022
@ashishdhingra ashishdhingra added the p3 This is a minor priority issue label Dec 14, 2022
@ashishdhingra ashishdhingra added p2 This is a standard priority issue and removed needs-review p3 This is a minor priority issue labels May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. module/sys-mgr-ext p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

2 participants