fix: failure on anonymous class with a method #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`jsii` used to fail when trying to generate deprecation warnings and
given a statement like this:
```ts
export function propertyInjectionDecorator<T extends Constructor>(ctr: T) {
// Important for the bug: the anonymous class extends something, *and*
// declares a method.
return class extends ctr {
public someMethod(): string {
return 'abc';
}
};
}
```
The reason is that during generation of deprecation warnings we iterate
over all classes and methods (both exported and unexported), and
generate a symbol identifier for every method; but this class is anonymous
so it doesn't have a symbol, and generating the identifier fails with
the error:
```
TypeError: Cannot read properties of undefined (reading 'flags')
at symbolIdentifier (.../jsii/lib/common/symbol-id.js:40:17)
```
Handle this by handling the case where we don't have a symbol
and returning `undefined`.
rix0rrr
force-pushed
the
huijbers/decorators
branch
from
efa57b2 to
c91e88b
Compare
rix0rrr
changed the title
rix0rrr
changed the title
rix0rrr
changed the title
iliapolo
reviewed
Mar 5, 2025
iliapolo
approved these changes
Mar 5, 2025
rix0rrr
added a commit
to aws/aws-cdk
that referenced
this pull request
Mar 10, 2025
This brings in this fix: aws/jsii-compiler#1824 This prevents jsii from failing on cases where we return an anonymous class with methods from a method.
mergify bot
pushed a commit
to aws/aws-cdk
that referenced
this pull request
Mar 10, 2025
This brings in this fix: aws/jsii-compiler#1824 This prevents jsii from failing on cases where we return an anonymous class with methods from a method. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws-cdk-automation
pushed a commit
that referenced
this pull request
Mar 10, 2025
`jsii` used to fail when trying to generate deprecation warnings and
given a statement like this:
```ts
export function propertyInjectionDecorator<T extends Constructor>(ctr: T) {
// Important for the bug: the anonymous class extends something, *and*
// declares a method.
return class extends ctr {
public someMethod(): string {
return 'abc';
}
};
}
```
The reason is that during generation of deprecation warnings we iterate
over all classes and methods (both exported and unexported), and
generate a symbol identifier for every method; but this class is
anonymous
so it doesn't have a symbol, and generating the identifier fails with
the error:
```
TypeError: Cannot read properties of undefined (reading 'flags')
at symbolIdentifier (.../jsii/lib/common/symbol-id.js:40:17)
```
Handle this by handling the case where we don't have a symbol
and returning `undefined`.
Fixes aws/aws-cdk#33213
---
By submitting this pull request, I confirm that my contribution is made
under the terms of the [Apache 2.0 license].
[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
---------
Co-authored-by: Eli Polonsky <Eli.polonsky@gmail.com>
(cherry picked from commit dbd4506)
aws-cdk-automation
pushed a commit
that referenced
this pull request
Mar 10, 2025
`jsii` used to fail when trying to generate deprecation warnings and
given a statement like this:
```ts
export function propertyInjectionDecorator<T extends Constructor>(ctr: T) {
// Important for the bug: the anonymous class extends something, *and*
// declares a method.
return class extends ctr {
public someMethod(): string {
return 'abc';
}
};
}
```
The reason is that during generation of deprecation warnings we iterate
over all classes and methods (both exported and unexported), and
generate a symbol identifier for every method; but this class is
anonymous
so it doesn't have a symbol, and generating the identifier fails with
the error:
```
TypeError: Cannot read properties of undefined (reading 'flags')
at symbolIdentifier (.../jsii/lib/common/symbol-id.js:40:17)
```
Handle this by handling the case where we don't have a symbol
and returning `undefined`.
Fixes aws/aws-cdk#33213
---
By submitting this pull request, I confirm that my contribution is made
under the terms of the [Apache 2.0 license].
[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
---------
Co-authored-by: Eli Polonsky <Eli.polonsky@gmail.com>
(cherry picked from commit dbd4506)
aws-cdk-automation
pushed a commit
that referenced
this pull request
Mar 10, 2025
`jsii` used to fail when trying to generate deprecation warnings and
given a statement like this:
```ts
export function propertyInjectionDecorator<T extends Constructor>(ctr: T) {
// Important for the bug: the anonymous class extends something, *and*
// declares a method.
return class extends ctr {
public someMethod(): string {
return 'abc';
}
};
}
```
The reason is that during generation of deprecation warnings we iterate
over all classes and methods (both exported and unexported), and
generate a symbol identifier for every method; but this class is
anonymous
so it doesn't have a symbol, and generating the identifier fails with
the error:
```
TypeError: Cannot read properties of undefined (reading 'flags')
at symbolIdentifier (.../jsii/lib/common/symbol-id.js:40:17)
```
Handle this by handling the case where we don't have a symbol
and returning `undefined`.
Fixes aws/aws-cdk#33213
---
By submitting this pull request, I confirm that my contribution is made
under the terms of the [Apache 2.0 license].
[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
---------
Co-authored-by: Eli Polonsky <Eli.polonsky@gmail.com>
(cherry picked from commit dbd4506)
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 10, 2025
# Backport This will backport the following commits from `main` to `maintenance/v5.6`: - [fix: failure on anonymous class with a method (#1824)](#1824) <!--- Backport version: 9.5.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) Co-authored-by: Rico Hermans <rix0rrr@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 10, 2025
# Backport This will backport the following commits from `main` to `maintenance/v5.5`: - [fix: failure on anonymous class with a method (#1824)](#1824) <!--- Backport version: 9.5.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) Co-authored-by: Rico Hermans <rix0rrr@gmail.com>
paulhcsun
pushed a commit
to paulhcsun/aws-cdk
that referenced
this pull request
Mar 11, 2025
This brings in this fix: aws/jsii-compiler#1824 This prevents jsii from failing on cases where we return an anonymous class with methods from a method. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsiiused to fail when trying to generate deprecation warnings andgiven a statement like this:
The reason is that during generation of deprecation warnings we iterate
over all classes and methods (both exported and unexported), and
generate a symbol identifier for every method; but this class is anonymous
so it doesn't have a symbol, and generating the identifier fails with
the error:
Handle this by handling the case where we don't have a symbol
and returning
undefined.Fixes aws/aws-cdk#33213
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.