Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed URL color visibility issues on some themes #154

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

Jurredr
Copy link
Contributor

@Jurredr Jurredr commented Oct 31, 2024

Problem

URLs sent to chat by the user are barely visible in the VSCode light theme, which is used widely by developers, so for UX reasons this should be addressed.

Solution

Use an alternate color for links sent in cards with type prompt.

Tests

  • I have tested this change on VSCode
  • I have tested this change on JetBrains

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorry, something went wrong.

@Jurredr Jurredr self-assigned this Oct 31, 2024
@Jurredr Jurredr requested a review from a team as a code owner October 31, 2024 15:54
@Jurredr Jurredr linked an issue Oct 31, 2024 that may be closed by this pull request
4 tasks
@Jurredr Jurredr added the bug Something isn't working label Oct 31, 2024
@Jurredr Jurredr merged commit e1f2546 into main Oct 31, 2024
1 check passed
@dogusata dogusata deleted the 151-urls-barely-visible-on-vscode-light-theme branch November 21, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URLs barely visible on VSCode light theme
2 participants