-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
163 quick action commands confirmation #164
Conversation
@justinmk3 We've mainly added that checklist to encourage contributors outside of the core team to think about actually testing larger (possibly breaking) changes in IDEs, as we've had some contributions come through which seemed fine at first but ended up not working properly in the actual IDE environments. So, its purpose is not to require every single PR to be fully tested on both VSCode and JetBrains necessarily, but more to encourage it, especially for bigger / more impactful changes. |
Everyone just ignores it, so it's noise. Noise should be reduced. |
I think it'd be better to add an alternative option stating something along the lines of "This PR doesn't necessarily require in-IDE testing". It's not being ignored in every PR, and the main reason for adding it was more so aimed at preventing external contributors from not being mindful about testing. Currently, we do not really have active external contributors. |
No, we're not gonna add such kind of option and this PR definitely requires a test on vscode and jetbrains. Since it is customer facing, it is best to see them also in VSCode and IntelliJ before merging. As an additional note, let me mention the regression we've created related with the liveserver. Our tests were passing, everything was looking ok but we'vet caused the installation process to brake for the VSCode (and also most likely the JetBrains). Depending on the PR (like changing some text etc. or just adding a new test into e2e tests) we can decide it is required or not. |
We'll ask for a specific reason to ignore it in the PRs. We want to avoid any kind of regression as much as possible. And this checks shouldn't be skipped. Again, as an example: to avoid regressions like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After its being checked for VSCode and JetBrains, it can be merged! Great work!
Tested, fully works in both IDEs! |
Problem
Quick commands without parameters would instantly run when clicked through the menu.
Solution
Instead of instantly running the command, we show a confirmation text in the prompt input, which can be confirmed by pressing enter and denied by unfocusing or pressing escape.
Tests
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.