[bug] buttons render in reverse order #179
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Buttons seem to be rendered in reverse order. As you can see in the video, the buttons from left to right are Build and execute Modify and Skip and finish, this is when adding the buttons in the list in the reverse way, i.e. adding Skip and finish first and Build and execute last.
However: when narrowing the chat window the button appears on the top is Skip and finish which aligns with what seems intuitive.
Solution
The buttons still show up in the reversed order, as we don't want to suddenly break everyone's button ordering. The order when wrapped has been fixed to be consistent with the reversed order, though. A deprecation notice has been added as a notice that we will make sure the order is no longer reversed starting from the next major version.
Screen.Recording.2024-11-22.at.13.59.36.mov
Tests
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.