[improvement] consider hiding cursor in prompt input during command confirmation #183
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogusata
approved these changes
Nov 22, 2024
Jurredr
deleted the
178-improvement-consider-hiding-cursor-in-prompt-input-during-command-confirmation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, when a command is waiting to be confirmed to be sent, the cursor still blinks in the prompt input textarea, even though the user can't type anything. Someone reported this as unexpected behavior, so an alternative should be considered.
Solution
Cursor is hidden when in command confirmation state. Also, now the command confirmation only shows up when a command is selected in the list through either
taborspace(soenter/ clicking will instantly send the command again, except for when there are arguments / parameters of course).Tests
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.