Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code scanning alert - Insecure randomness #217

Closed
1 task
Jurredr opened this issue Jan 8, 2025 · 1 comment
Closed
1 task

Fix code scanning alert - Insecure randomness #217

Jurredr opened this issue Jan 8, 2025 · 1 comment
Assignees
@Jurredr
Labels
improvement Improvement of an existing feature

Comments

@Jurredr
Copy link
Contributor

Jurredr commented Jan 8, 2025

Tracking issue for:

Note

Even though cryptographic safety is not really relevant to anything we're doing with IDs, it's good practice to make use of Node's built-in crypto package anyways, over implementing our own less optimized solution.
@Jurredr Jurredr added the improvement Improvement of an existing feature label Jan 8, 2025
@Jurredr Jurredr self-assigned this Jan 8, 2025
@Jurredr Jurredr linked a pull request Jan 8, 2025 that will close this issue
feat: improved random UID generation through crypto module #218
Closed
2 tasks
@Jurredr Jurredr closed this as completed Jan 8, 2025
@Jurredr
Copy link
Contributor Author

Jurredr commented Jan 8, 2025

Closed, see https://github.com/aws/mynah-ui/security/code-scanning/8 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jurredr Jurredr

Labels
improvement Improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: improved random UID generation through crypto module aws/mynah-ui
1 participant
@Jurredr