Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested list parsing doesn't work in Mynah UI #97

Closed
2 of 4 tasks
tverney opened this issue Aug 14, 2024 · 1 comment · Fixed by aws/aws-toolkit-vscode#5487
Closed
2 of 4 tasks

Nested list parsing doesn't work in Mynah UI #97

tverney opened this issue Aug 14, 2024 · 1 comment · Fixed by aws/aws-toolkit-vscode#5487
Labels
bug Something isn't working

Comments

@tverney
Copy link
Contributor

tverney commented Aug 14, 2024

Problem

We've seen responses from LLM being answered in a wrong level when nested (see screenshots).

image (1)
Screenshot 2024-08-14 at 1 21 36 PM

Steps to reproduce the issue

If I copy the file for nested examples in Mynah UI, add as an input response, it doesn't format/work as expected.
Screenshot 2024-08-14 at 1 42 18 PM
Screenshot 2024-08-14 at 1 42 48 PM

Expected behaviour

It should parse it as expected in Markdown spec: https://ref.coddy.tech/markdown/markdown-nested-lists

System details

  • OS:
  • Tested enviroment:
    • Web (Demo app)
    • VSCode Amazon Q Chat
    • JetBrains IntelliJ Amazon Q Chat
  • Enviroment extension version (if applicable):
  • Enviroment is remote
@tverney tverney added the bug Something isn't working label Aug 14, 2024
@volodkevych
Copy link
Contributor

volodkevych commented Aug 21, 2024 •
edited
Loading

Thanks for reporting this.

Formatting is also broken for other functionality. For example, if I "Send to prompt" selected code block, code indentation is lost:
Screenshot 2024-08-21 at 10 19 16

The issue was caused by this change: https://github.com/aws/mynah-ui/pull/72/files.

This was referenced Aug 21, 2024
Merged
Merged
@volodkevych volodkevych mentioned this issue Aug 23, 2024
Closed
6 tasks
justinmk3 pushed a commit to aws/aws-toolkit-vscode that referenced this issue Aug 23, 2024
@volodkevych
fix(amazonq): Release mynah-ui v 4.15.7 with a bug fix #5487
5b855a0 
## Problem
New version of MynahUI requires release in vscode.

## Solution
Release new version of MynahUI with the following bug fix: [Nested list
parsing doesn't work in Mynah
UI](aws/mynah-ui#97).
MynahUI v4.15.7 release notes:
https://github.com/aws/mynah-ui/releases/tag/v4.15.7
The release fixes:
- markdown formatting in nested lists in response prompt
- code indentation in response prompt
jpinkney-aws pushed a commit to aws/aws-toolkit-vscode that referenced this issue Aug 26, 2024
@volodkevych @jpinkney-aws
fix(amazonq): Release mynah-ui v 4.15.7 with a bug fix #5487
52926f5 
## Problem
New version of MynahUI requires release in vscode.

## Solution
Release new version of MynahUI with the following bug fix: [Nested list
parsing doesn't work in Mynah
UI](aws/mynah-ui#97).
MynahUI v4.15.7 release notes:
https://github.com/aws/mynah-ui/releases/tag/v4.15.7
The release fixes:
- markdown formatting in nested lists in response prompt
- code indentation in response prompt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@tverney @volodkevych