Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy/paste for inline code #100

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Fix copy/paste for inline code #100

merged 4 commits into from
Aug 26, 2024

Conversation

volodkevych
Copy link
Contributor

Problem

If you copy from the Mynah card with inline code and paste it into another place, it will contain new line breaks around inline code text.
The problem is described in more details in related issue: #98

Solution

Avoid using block elements for inline code.

Before:
Screenshot 2024-08-21 at 18 12 28
After:
Screenshot 2024-08-21 at 18 12 44

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@volodkevych volodkevych requested a review from a team as a code owner August 21, 2024 16:23
viktorsaws
viktorsaws previously approved these changes Aug 22, 2024
@volodkevych volodkevych dismissed viktorsaws’s stale review August 22, 2024 13:17

The merge-base changed after approval.

@volodkevych volodkevych force-pushed the fix-inline-code-copy-paste branch from 22b3c21 to 13760be Compare August 22, 2024 16:19
@volodkevych
Copy link
Contributor Author

This change was verified in web, but still needs to be verified in IDEs.

dogusata
dogusata previously approved these changes Aug 26, 2024
@dogusata dogusata merged commit b621ed3 into main Aug 26, 2024
1 check passed
@dogusata dogusata deleted the fix-inline-code-copy-paste branch August 26, 2024 11:57
@dogusata dogusata restored the fix-inline-code-copy-paste branch August 26, 2024 11:57
@dogusata dogusata linked an issue Aug 26, 2024 that may be closed by this pull request
3 tasks
@dogusata dogusata deleted the fix-inline-code-copy-paste branch August 26, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug report: Copy paste from MynahUI should not contain unnecessary line breaks
3 participants