Test fixes for playwright library migration

.gitignore

@@ -10,4 +10,5 @@ node_modules
 package-lock.json
 .gitcommit
 .vscode
-__reports__/
+__reports__/
+e2e-results/

ui-tests/__test__/flows/feedback-form/cancel-feedback-form.ts

@@ -1,4 +1,4 @@
-import { Page } from 'playwright/test';
+import { expect, Page } from 'playwright/test';
 import { getSelector, waitForAnimationEnd } from '../../helpers';
 import testIds from '../../../../src/helper/test-ids';
 
@@ -9,6 +9,6 @@ export const cancelFeedbackForm = async (page: Page, skipScreenshots?: boolean):
   await waitForAnimationEnd(page);
 
   if (skipScreenshots !== true) {
-    expect(await page.screenshot()).toMatchImageSnapshot();
+    expect(await page.screenshot()).toMatchSnapshot();
   }
 };

ui-tests/__test__/flows/feedback-form/render-downvote-result.ts

@@ -1,9 +1,9 @@
-import { Page } from 'playwright/test';
+import { expect, Page } from 'playwright/test';
 import { getSelector, waitForAnimationEnd } from '../../helpers';
 import testIds from '../../../../src/helper/test-ids';
 
 export const renderDownvoteResult = async (page: Page, skipScreenshots?: boolean): Promise<void> => {
-  await page.evaluate((body) => {
+  await page.evaluate(() => {
     const selectedTabId = window.mynahUI.getSelectedTabId();
     if (selectedTabId != null) {
       window.mynahUI.updateStore(selectedTabId, {
@@ -26,6 +26,6 @@ export const renderDownvoteResult = async (page: Page, skipScreenshots?: boolean
   await waitForAnimationEnd(page);
 
   if (skipScreenshots !== true) {
-    expect(await page.screenshot()).toMatchImageSnapshot();
+    expect(await page.screenshot()).toMatchSnapshot();
   }
 };

ui-tests/__test__/flows/feedback-form/render-feedback-form.ts

@@ -1,4 +1,4 @@
-import { Page } from 'playwright/test';
+import { expect, Page } from 'playwright/test';
 import { getSelector, waitForAnimationEnd } from '../../helpers';
 import testIds from '../../../../src/helper/test-ids';
 
@@ -41,6 +41,6 @@ export const renderFeedbackForm = async (page: Page, skipScreenshots?: boolean):
   expect(cancelButton).toBeDefined();
 
   if (skipScreenshots !== true) {
-    expect(await page.screenshot()).toMatchImageSnapshot();
+    expect(await page.screenshot()).toMatchSnapshot();
   }
 };

ui-tests/__test__/flows/feedback-form/render-upvote-result.ts

@@ -1,9 +1,9 @@
-import { Page } from 'playwright/test';
+import { expect, Page } from 'playwright/test';
 import { getSelector, waitForAnimationEnd } from '../../helpers';
 import testIds from '../../../../src/helper/test-ids';
 
 export const renderUpvoteResult = async (page: Page, skipScreenshots?: boolean): Promise<void> => {
-  await page.evaluate((body) => {
+  await page.evaluate(() => {
     const selectedTabId = window.mynahUI.getSelectedTabId();
     if (selectedTabId != null) {
       window.mynahUI.updateStore(selectedTabId, {
@@ -26,6 +26,6 @@ export const renderUpvoteResult = async (page: Page, skipScreenshots?: boolean):
   await waitForAnimationEnd(page);
 
   if (skipScreenshots !== true) {
-    expect(await page.screenshot()).toMatchImageSnapshot();
+    expect(await page.screenshot()).toMatchSnapshot();
   }
 };

ui-tests/__test__/flows/feedback-form/render-vote-buttons.ts

@@ -1,4 +1,4 @@
-import { Page } from 'playwright/test';
+import { expect, Page } from 'playwright/test';
 import { waitForAnimationEnd } from '../../helpers';
 import { openNewTab } from '../open-new-tab';
 import { closeTab } from '../close-tab';
@@ -7,7 +7,7 @@ export const renderVoteButtons = async (page: Page, skipScreenshots?: boolean):
   await closeTab(page, false, true);
   await openNewTab(page, false, true);
 
-  await page.evaluate((body) => {
+  await page.evaluate(() => {
     const selectedTabId = window.mynahUI.getSelectedTabId();
     if (selectedTabId != null) {
       window.mynahUI.updateStore(selectedTabId, {
@@ -25,6 +25,6 @@ export const renderVoteButtons = async (page: Page, skipScreenshots?: boolean):
   await waitForAnimationEnd(page);
 
   if (skipScreenshots !== true) {
-    expect(await page.screenshot()).toMatchImageSnapshot();
+    expect(await page.screenshot()).toMatchSnapshot();
   }
 };

ui-tests/__test__/flows/feedback-form/submit-feedback-form.ts

@@ -1,4 +1,4 @@
-import { Page } from 'playwright/test';
+import { expect, Page } from 'playwright/test';
 import { getSelector, waitForAnimationEnd } from '../../helpers';
 import testIds from '../../../../src/helper/test-ids';
 
@@ -35,6 +35,6 @@ export const submitFeedbackForm = async (page: Page, skipScreenshots?: boolean):
   await waitForAnimationEnd(page);
 
   if (skipScreenshots !== true) {
-    expect(await page.screenshot()).toMatchImageSnapshot();
+    expect(await page.screenshot()).toMatchSnapshot();
   }
 };

ui-tests/__test__/flows/navigate-prompts/navigate-back-to-current-prompt-with-code-attachment.ts

@@ -1,4 +1,4 @@
-import { Page } from 'playwright/test';
+import { expect, Page } from 'playwright/test';
 import { getSelector, waitForAnimationEnd } from '../../helpers';
 import testIds from '../../../../src/helper/test-ids';
 import { closeTab } from '../close-tab';
@@ -35,6 +35,6 @@ export const navigateBackToCurrentPromptWithCodeAttachment = async (page: Page,
   expect(codeAttachmentContent).toBe('This is an unsent code attachment');
 
   if (skipScreenshots !== true) {
-    expect(await page.screenshot()).toMatchImageSnapshot();
+    expect(await page.screenshot()).toMatchSnapshot();
   }
 };

ui-tests/__test__/flows/navigate-prompts/navigate-back-to-current-prompt.ts

@@ -1,4 +1,4 @@
-import { Page } from 'playwright/test';
+import { expect, Page } from 'playwright/test';
 import { getSelector, waitForAnimationEnd } from '../../helpers';
 import testIds from '../../../../src/helper/test-ids';
 import { closeTab } from '../close-tab';
@@ -27,6 +27,6 @@ export const navigateBackToCurrentPrompt = async (page: Page, skipScreenshots?:
   expect(await promptInput.inputValue()).toBe('This is the second unsent user prompt');
 
   if (skipScreenshots !== true) {
-    expect(await page.screenshot()).toMatchImageSnapshot();
+    expect(await page.screenshot()).toMatchSnapshot();
   }
 };

ui-tests/__test__/flows/navigate-prompts/navigate-prompts-down.ts

@@ -1,4 +1,4 @@
-import { Page } from 'playwright/test';
+import { expect, Page } from 'playwright/test';
 import { getSelector, waitForAnimationEnd } from '../../helpers';
 import testIds from '../../../../src/helper/test-ids';
 import { closeTab } from '../close-tab';
@@ -29,6 +29,6 @@ export const navigatePromptsDown = async (page: Page, skipScreenshots?: boolean)
   expect(await promptInput.inputValue()).toBe('This is the second user prompt');
 
   if (skipScreenshots !== true) {
-    expect(await page.screenshot()).toMatchImageSnapshot();
+    expect(await page.screenshot()).toMatchSnapshot();
   }
 };

ui-tests/__test__/flows/navigate-prompts/navigate-prompts-first-last-line-check.ts

@@ -1,4 +1,4 @@
-import { Page } from 'playwright/test';
+import { expect, Page } from 'playwright/test';
 import { getSelector, waitForAnimationEnd } from '../../helpers';
 import testIds from '../../../../src/helper/test-ids';
 import { closeTab } from '../close-tab';

ui-tests/__test__/flows/navigate-prompts/navigate-prompts-to-empty.ts

@@ -1,4 +1,4 @@
-import { Page } from 'playwright/test';
+import { expect, Page } from 'playwright/test';
 import { getSelector, waitForAnimationEnd } from '../../helpers';
 import testIds from '../../../../src/helper/test-ids';
 import { closeTab } from '../close-tab';
@@ -22,6 +22,6 @@ export const navigatePromptsToEmpty = async (page: Page, skipScreenshots?: boole
   expect(await promptInput.inputValue()).toBe('');
 
   if (skipScreenshots !== true) {
-    expect(await page.screenshot()).toMatchImageSnapshot();
+    expect(await page.screenshot()).toMatchSnapshot();
   }
 };

ui-tests/__test__/flows/navigate-prompts/navigate-prompts-up.ts

@@ -1,5 +1,5 @@
 // navigatePromptsUp.ts
-import { Page } from 'playwright/test';
+import { expect, Page } from 'playwright/test';
 import { getSelector, waitForAnimationEnd } from '../../helpers';
 import testIds from '../../../../src/helper/test-ids';
 import { closeTab } from '../close-tab';
@@ -20,6 +20,6 @@ export const navigatePromptsUp = async (page: Page, skipScreenshots?: boolean):
   expect(await promptInput.inputValue()).toBe('This is the first user prompt');
 
   if (skipScreenshots !== true) {
-    expect(await page.screenshot()).toMatchImageSnapshot();
+    expect(await page.screenshot()).toMatchSnapshot();
   }
 };

ui-tests/__test__/flows/navigate-prompts/stay-on-current-prompt.ts

@@ -1,4 +1,4 @@
-import { Page } from 'playwright/test';
+import { expect, Page } from 'playwright/test';
 import { getSelector, waitForAnimationEnd } from '../../helpers';
 import testIds from '../../../../src/helper/test-ids';
 import { closeTab } from '../close-tab';
@@ -22,6 +22,6 @@ export const stayOnCurrentPrompt = async (page: Page, skipScreenshots?: boolean)
   expect(await promptInput.inputValue()).toBe('This is the first unsent user prompt');
 
   if (skipScreenshots !== true) {
-    expect(await page.screenshot()).toMatchImageSnapshot();
+    expect(await page.screenshot()).toMatchSnapshot();
   }
 };

ui-tests/__test__/main.spec.ts

@@ -211,40 +211,40 @@ test.describe('Open MynahUI', () => {
     test('should navigate down to current empty prompt', async ({ page }) => {
       await navigatePromptsToEmpty(page);
     });
-    it('should navigate up/down only if on first/last line', async () => {
+    test('should navigate up/down only if on first/last line', async ({ page }) => {
       await navigatePromptsFirstLastLineCheck(page);
     });
 
-    it('should stay on current prompt', async () => {
+    test('should stay on current prompt', async ({ page }) => {
       await stayOnCurrentPrompt(page);
     });
 
-    it('should navigate back to current prompt', async () => {
+    test('should navigate back to current prompt', async ({ page }) => {
       await navigateBackToCurrentPrompt(page);
     });
 
-    it('should navigate back to current prompt with code attachment', async () => {
+    test('should navigate back to current prompt with code attachment', async ({ page }) => {
       await navigateBackToCurrentPromptWithCodeAttachment(page);
     });
   });
 
-  describe('Feedback form', () => {
-    it('should render vote buttons', async () => {
+  test.describe('Feedback form', () => {
+    test('should render vote buttons', async ({ page }) => {
       await renderVoteButtons(page);
     });
-    it('should render upvote results', async () => {
+    test('should render upvote results', async ({ page }) => {
       await renderUpvoteResult(page);
     });
-    it('should render downvote results', async () => {
+    test('should render downvote results', async ({ page }) => {
       await renderDownvoteResult(page);
     });
-    it('should render feedback form', async () => {
+    test('should render feedback form', async ({ page }) => {
       await renderFeedbackForm(page);
     });
-    it('should cancel feedback form', async () => {
+    test('should cancel feedback form', async ({ page }) => {
       await cancelFeedbackForm(page);
     });
-    it('should submit feedback form', async () => {
+    test('should submit feedback form', async ({ page }) => {
       await submitFeedbackForm(page);
     });
   });