Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PR for testing new Dockerized testing #233

Open
wants to merge 52 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
83e104e
Updated tests:e2e script for compatibility with new dockerized testin…
Jurredr Jan 27, 2025
4268066
Modified e2e docker script and added local e2e testing script
Jurredr Jan 27, 2025
9be18d0
Added dockerfile for E2E testing
Jurredr Jan 27, 2025
a8bd82d
Added trace npm scripts for Playwright tracing
Jurredr Jan 27, 2025
e8382d9
Renamed docker image and container names
Jurredr Jan 28, 2025
6738907
Updated node version in Dockerfile
Jurredr Jan 28, 2025
f104dc8
Added separate npm script for building docker image
Jurredr Jan 28, 2025
3a63184
Changed trace mode to upload traces for each failed test
Jurredr Jan 28, 2025
c4aebd8
Added JUnit xml reporter to Playwright
Jurredr Jan 28, 2025
0aae515
Updated Docker run command
Jurredr Jan 28, 2025
8a2b3f1
Added command to inspect Docker E2E test results
Jurredr Jan 28, 2025
1a9bf77
Changed docker inspect target name to "flarechatui-e2e-container"
Jurredr Jan 28, 2025
f04f641
Added docker clean script / step to container runner
Jurredr Jan 28, 2025
a21663d
Removed test results / last run file from default ui-tests dir
Jurredr Jan 28, 2025
0ae6c09
Added JUnit reporter for Playwright
Jurredr Jan 29, 2025
bffafdc
Migrated jest-playwright to playwright/test
Jurredr Jan 29, 2025
438608b
Added test reports to git ignore
Jurredr Jan 30, 2025
b5f193f
Generate all test results in one separate root directory
Jurredr Jan 30, 2025
9ee2bda
Ignore Dockerfile from eslint
Jurredr Jan 30, 2025
ba9a8aa
Merge branch 'main' into jurredr/dockerized-testing
Jurredr Jan 30, 2025
23b144a
Use npm install instead of ci in docker image
Jurredr Jan 30, 2025
a5acfea
Test fixes for playwright library migration
Jurredr Jan 30, 2025
119bb9b
Removed all existing image snapshots
Jurredr Feb 3, 2025
1775fbb
Updated dockerfile to only include relevant files and folders in dock…
Jurredr Feb 3, 2025
0633e6b
Implemented new GitHub CI script for E2E testing through Docker
Jurredr Feb 3, 2025
623fbb4
Ignore e2e-results folder from eslint
Jurredr Feb 3, 2025
af44e63
ci: only send slack message on non-draft prs
Jurredr Feb 4, 2025
5e3675d
Fixed GitHub new_pr workflow, only runs for non-draft PRs properly now
Jurredr Feb 4, 2025
cb221ed
Fixed non-draft PR check in GitHub workflow
Jurredr Feb 4, 2025
be5bae0
Merge branch 'main' into jurredr/dockerized-testing
Jurredr Feb 4, 2025
c5913b9
Merge branch 'main' into jurredr/dockerized-testing
Jurredr Feb 4, 2025
e4d226c
Made all individual E2E tests run on their own
Jurredr Feb 5, 2025
1bca731
Added and tested form tests to work individually with new E2E flow
Jurredr Feb 5, 2025
dcb6ddf
Fully run all tests in parallel
Jurredr Feb 5, 2025
3fad9f3
Fixed all existing test flows to work with new parallel runner
Jurredr Feb 5, 2025
2c5583e
Remove failure check on uploading of artifacts in new_pr test workflow
Jurredr Feb 11, 2025
9eec00e
Extracted e2e testing to separate workflow, added dockerized E2E step…
Jurredr Feb 11, 2025
67bea9b
Temporarily disabled slack messager for new prs while testing e2e wor…
Jurredr Feb 11, 2025
ef60fd0
Attempt at fixing linting errors
Jurredr Feb 11, 2025
069a00b
Added build step before linting
Jurredr Feb 11, 2025
87151df
New lint fix attempt
Jurredr Feb 11, 2025
0e6f7b2
Fixed incorrect npm install command in e2e build step
Jurredr Feb 11, 2025
ad6321a
e2e build fix
Jurredr Feb 11, 2025
361080a
Force Playwright workers to be 6
Jurredr Feb 11, 2025
6b448da
continue e2e workflow on test suite error
Jurredr Feb 11, 2025
26e985c
Merged main into dockerized testing branch
Jurredr Mar 4, 2025
41aa55e
Updated test result reporter type to jest-junit
Jurredr Mar 4, 2025
36e37a0
Removed commented code
Jurredr Mar 4, 2025
e4e600a
Removed console log from e2e test
Jurredr Mar 4, 2025
59373dd
Updated incorrect ui-test result paths
Jurredr Mar 4, 2025
785be97
Specify branch for snapshot replacement commit, change test reporter …
Jurredr Mar 4, 2025
fc46244
Ignore zip and xml files from eslint
Jurredr Mar 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Attempt at fixing linting errors
  • Loading branch information
Jurredr committed Feb 11, 2025
commit ef60fd01d466780aef8a954129d3b007d38324f6
Original file line number Diff line number Diff line change
@@ -86,7 +86,7 @@
// Reference hover
const markPosition = await answerCard.evaluate(node => node.querySelectorAll('pre')[2]?.querySelector(':scope > code > mark')?.getBoundingClientRect());
if (markPosition != null) {
await page.mouse.move(markPosition?.top + 2, markPosition?.left + 2);
await page.mouse.move(markPosition.top + 2, markPosition.left + 2);

Check failure on line 89 in ui-tests/__test__/flows/markdown-parser/markdown-parser.ts

GitHub Actions / e2e / e2e

Invalid operand for a '+' operation. Operands must each be a number or string. Got `any`

Check failure on line 89 in ui-tests/__test__/flows/markdown-parser/markdown-parser.ts

GitHub Actions / e2e / e2e

Invalid operand for a '+' operation. Operands must each be a number or string. Got `any`
await waitForAnimationEnd(page);
}
expect(page.getByText('Hello Reference Tracker')).toBeDefined();
2 changes: 1 addition & 1 deletion ui-tests/__test__/flows/welcome-mode.ts
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@ export const welcomeMode = async (page: Page, skipScreenshots?: boolean): Promis
}, welcomeCardId);

await page.mouse.move(0, 0);
const chatWrapperSelector = `${getSelector(testIds.chat.wrapper)}[mynah-tab-id="${newTabId}"]`;
const chatWrapperSelector = `${getSelector(testIds.chat.wrapper)}[mynah-tab-id="${String(newTabId)}"]`;
const chatWrapper = await page.waitForSelector(chatWrapperSelector);
expect(chatWrapper).toBeDefined();

Loading
Oops, something went wrong.