Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jurredr/context description truncate #259

Merged
merged 4 commits into from
Mar 6, 2025

Conversation

Jurredr
Copy link
Contributor

@Jurredr Jurredr commented Mar 4, 2025

Problem

  • Context item descriptions could be too long, causing overflow and lack of readability.

Solution

Truncate with ellipsis in the middle.
Screenshot 2025-03-04 at 14 49 10

Screenshot 2025-03-04 at 14 22 58

Tests

  • I have tested this change on VSCode
  • I have tested this change on JetBrains

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Jurredr Jurredr self-assigned this Mar 4, 2025
@Jurredr Jurredr requested a review from a team as a code owner March 4, 2025 13:29
@dogusata
Copy link
Collaborator

dogusata commented Mar 5, 2025

A few more things as a general feedback:

  • What will happen if the screen size changes? Will we recalculate? Why?
  • It feels like that is too much calculation, and with a hidden element etc. Can we simplify it?
  • It can try to calculate some string before even actually the component is being rendered? Adding more delay wouldn't help on that. We're generally thinking that all components can be used in any place, this may not work in "any" place.

@dogusata dogusata merged commit 7609feb into main Mar 6, 2025
5 checks passed
@dogusata dogusata deleted the jurredr/context-description-truncate branch March 6, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants