Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely replace legacy pkey impls with EVP impl #5149

Open
lrstewart opened this issue Feb 27, 2025 · 0 comments
Open

Completely replace legacy pkey impls with EVP impl #5149

lrstewart opened this issue Feb 27, 2025 · 0 comments

Comments

@lrstewart
Copy link
Contributor

Security issue notifications

If you discover a potential security issue in s2n we ask that you notify
AWS Security via our vulnerability reporting page. Please do not create a public github issue.

Problem:

Last remaining item from #5105

I replaced the sign/verify methods for all pkeys with the EVP sign/verify. However, we still use legacy logic for other options, like RSA encryption/decryption and the key match check.

Solution:

Rip out the rest of the old legacy pkey logic and replace it with EVP logic. This will be a nice simplification.

  • Does this change what S2N sends over the wire? no
  • Does this change any public APIs? no
  • Which versions of TLS will this impact?

Requirements / Acceptance Criteria:

What must a solution address in order to solve the problem? How do we know the solution is complete?

  • RFC links: Links to relevant RFC(s)
  • Related Issues: Link any relevant issues
  • Will the Usage Guide or other documentation need to be updated?
  • Testing: How will this change be tested? Call out new integration tests, functional tests, or particularly interesting/important unit tests.
    • Will this change trigger SAW changes? Changes to the state machine, the s2n_handshake_io code that controls state transitions, the DRBG, or the corking/uncorking logic could trigger SAW failures.
    • Should this change be fuzz tested? Will it handle untrusted input? Create a separate issue to track the fuzzing work.

Out of scope:

Is there anything the solution will intentionally NOT address?

@lrstewart lrstewart changed the title Completely replace old pkey code Completely replace legacy pkey impls with EVP impl Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant