chore(ci): make the awslc fips install script version aware #5100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
reviewed
Feb 11, 2025
dougch
force-pushed
the
awslcfips_2024
branch
from
875d454 to
7715011
Compare
lrstewart
reviewed
Feb 18, 2025
Co-authored-by: Lindsay Stewart <stewart.r.lindsay@gmail.com>
goatgoose
approved these changes
Feb 18, 2025
Co-authored-by: Sam Clark <3758302+goatgoose@users.noreply.github.com>
Co-authored-by: Sam Clark <3758302+goatgoose@users.noreply.github.com>
lrstewart
approved these changes
Feb 25, 2025
dougch
added a commit
to dougch/s2n-tls
that referenced
this pull request
Mar 3, 2025
Co-authored-by: Lindsay Stewart <stewart.r.lindsay@gmail.com> Co-authored-by: Sam Clark <3758302+goatgoose@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
none
Description of changes:
AWS Libcrypto FIPS 3.0 needs to be part of our testing. This PR makes converts the 2022 installer into a symlink, with the underlying script choosing the feature branch based on the command name. This is an attempt at anticipating future versions of lc.
Call-outs:
The original awslc install script, which installs the 2021/v1 FIPS code, was not altered.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? locally
Remember:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.