-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(integv2): add partial support for OpenSSL 3.0 provider #5131
Conversation
Also, I think there are some tests that aren't passing under openssl 3.0 with this PR? Let's call that out in the PR description. And I'd also vote to edit the CR title to |
Co-authored-by: James Mayclin <maycj@amazon.com>
Co-authored-by: James Mayclin <maycj@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with the requested changes.
Co-authored-by: James Mayclin <maycj@amazon.com>
Co-authored-by: James Mayclin <maycj@amazon.com>
Co-authored-by: James Mayclin <maycj@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the nits are addressed.
Co-authored-by: James Mayclin <maycj@amazon.com>
Resolved issues:
Description of changes:
Problem
This PR removes the constraint that forces the OpenSSL provider executable to be from version 1.1.1, allowing support for modern OSs that use OpenSSL 3.0. The "version supported" method has been updated to accommodate OpenSSL 3.0, which only supports TLS 1.3 and TLS 1.2 by default. Additionally, Certificates.RSA_1024 tests are now skipped for OpenSSL 3.0.
Future Investigation
After adding openSSL 3.0 as a provider, the below test cases are failing and need more investigation
test_serialization.py
test_renegotiate_apache.py
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.