fix(ruff): resolve linting errors detected by Ruff #5140
Conversation
|
Closing until #5138 is merged in |
|
What are the next steps to get the linter running in CI? |
johubertj
changed the title
johubertj
changed the title
johubertj
force-pushed
the
test/integv2-linting-ruff
branch
from
9ca9943 to
73987ea
Compare
| cmd_line.extend( | ||
| ["-cipher", "TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256"] | ||
| ) | ||
| elif self.options.cipher == Ciphersuites.TLS_AES_128_GCM_256: |
There was a problem hiding this comment.
What exactly is happening here? Don't we need to be skipping these tests still?
There was a problem hiding this comment.
These lines are causing linting errors because Ciphersuites doesn't exist as a class anymore. My theory is that someone deleted the Ciphersuites class but didn't fully clean all references of it. Also TLS_AES_256_GCM_384 and TLS_AES_128_GCM_256 are not referenced anywhere in the codebase.
Discussed with James, and we thought the best path forward was to clean this up and remove these checks~
There was a problem hiding this comment.
Hmm yeah it seems like what these were supposed to be was TLS_AES_256_GCM_SHA384 and TLS_AES_256_GCM_SHA256? This mistake has been with us since the very beginning of integv2. Minimally it doesn't seem like this change alters our test coverage at all.
Resolved Issues:
Partially addresses #5027
Description of Changes:
This pull request fixes manual linting errors identified by Ruff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.