ci: cleanup awslc-fips versioning #5156
Open
+35
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougch
changed the title
dougch
force-pushed
the
awslcfips_versioning
branch
from
6caeb8b to
9518f36
Compare
goatgoose
reviewed
Mar 5, 2025
lrstewart
reviewed
Mar 6, 2025
lrstewart
reviewed
Mar 6, 2025
goatgoose
reviewed
Mar 7, 2025
dougch
force-pushed
the
awslcfips_versioning
branch
from
990cfae to
432be8a
Compare
goatgoose
approved these changes
Mar 12, 2025
dougch
force-pushed
the
awslcfips_versioning
branch
from
21175e9 to
432be8a
Compare
lrstewart
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
none
Description of changes:
We've pinned our dependencies for awslc-fips at specific commits, but FIPS is special: it's a feature branch off main at release time and then each will only get security and bug fix updates.
We can reasonably assume these branches are stable and test with the tip of each branch.
For main, this also changes to using the latest release, instead of a pinned version.
Call-outs:
This PR also removes the FIPS flag from the original install script, since the 2021 certified version should be considered historical at this point.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? What manual testing was performed? WIP
How can you convince your reviewers that this PR is safe and effective? WIP
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.