-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(integv2): reduce parameter selection #5161
test(integv2): reduce parameter selection #5161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, spot checked one of the aarch64 jobs, run time reduced from 35min to 19min.
Could you include the diff in the collected tests in the PR description? before/after. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: it would be good to clarify the scope in the PR title. test(integv2): reduce parameter selection
Resolved issues:
Integ test bloat #4375
Description of changes:
Problem:
This PR reduces the number of certificates used in integration tests, limiting them to only the minimal required set, except for test_happy_path.py, which retains all certs for comprehensive coverage. Certain tests has slightly increased because we added ECDSA_521 to MINIMAL_TEST_CERTS
Testing
Verified that reducing the number of certificates did not impact coverage of other test parameters (buffer sizes, protocols, ciphers). The test compared the original and modified test outputs to ensure that all non-certificate parameters remained unchanged. Attached below is the test case.
📌 Testcase
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.