Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): pin symbolic-common #5166

Merged
merged 1 commit into from
Mar 6, 2025
Merged

chore(ci): pin symbolic-common #5166

merged 1 commit into from
Mar 6, 2025

Conversation

lrstewart
Copy link
Contributor

@lrstewart lrstewart commented Mar 5, 2025

Release Summary:

Description of changes:

The Rust CI is failing with:

error[E0599]: no method named `is_none_or` found for enum `Option` in the current scope
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/symbolic-common-12.14.0/src/path.rs:57:32
   |
57 |             return path.get(2).is_none_or(is_windows_separator);
   |                                ^^^^^^^^^^ help: there is a method with a similar name: `is_none`
For more information about this error, try `rustc --explain E0599`.
error: could not compile `symbolic-common` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...

Looks like one of our dependencies, "symbolic", started using the is_none_or in their latest release: getsentry/symbolic@0ba5f9c That was stabilized in 1.82.0.

Unfortunately, 1.82.0 is only 4.5 months old, and we have a policy of maintaining an MSRV at least 6mo old. So pin symbolic for another 1.5 months.

I did bump our toolchain to 1.81.0 though, which is exactly 6 months old.

Testing:

CI now passes, specifically "Standard Workspace Tests" in the generate action.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lrstewart lrstewart added this pull request to the merge queue Mar 6, 2025
Merged via the queue into aws:main with commit bd87a14 Mar 6, 2025
47 checks passed
@lrstewart lrstewart deleted the pin branch March 6, 2025 01:46
dougch pushed a commit to dougch/s2n-tls that referenced this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants