fix: include version file in the distribution #249
+3
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The __version__ can now be accessed at runtime. Tested with the following. We can see the version being copied by build. It also shows up in the sdist. ```bash python -m pip install build python -m build tar -xzf ./dist/sagemaker_core-1.0.24.tar.gz ls -l sagemaker_core-1.0.24 total 31 -rw-r--r-- 1 RM13 1049089 11558 Feb 12 16:54 LICENSE -rw-r--r-- 1 RM13 1049089 15 Feb 12 16:54 MANIFEST.in -rw-r--r-- 1 RM13 1049089 4945 Feb 24 13:57 PKG-INFO -rw-r--r-- 1 RM13 1049089 1441 Feb 24 13:54 pyproject.toml -rw-r--r-- 1 RM13 1049089 3647 Feb 12 16:54 README.rst -rw-r--r-- 1 RM13 1049089 133 Feb 24 13:57 setup.cfg drwxr-xr-x 1 RM13 1049089 0 Feb 24 13:57 src/ -rw-r--r-- 1 RM13 1049089 6 Feb 24 13:53 VERSION ``` Closes aws#248
jmahlik
requested a deployment
to
manual-approval
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version can now be accessed at runtime.
Tested with the following. We can see the version being copied by build. It also shows up in the sdist.
Closes #248
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.