Add feature of refreshing converted files if original files are modified #5204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just encountered the same issue and am glad to see that there is already a PR for this. Would love to see this merged. |
|
Hello, kind reminder, is there anything that I can do on my side to see this PR being merged? :) @Serene-Arc |
snejus
requested changes
Feb 20, 2025
pierreay
force-pushed
the
pr-feat-convert-refresh
branch
from
716995e to
1ea648d
Compare
|
Well, I just rebased on master anticipating a future merge, but I'm not sure the moment was right. ^^" |
|
Now the only missing bit is a note in the changelog as this is a new feature :) |
@snejus Done! In fact the changelog entry was already there, but was lost in others entries of nearly one year ago since this is a pretty old PR ahah. :) |
Co-authored-by: Šarūnas Nejus <snejus@protonmail.com>
- Logic refactoring - `util.syspath` is redundant because already called in `util.remove` Co-authored-by: Šarūnas Nejus <snejus@protonmail.com>
- `util.syspath` is redundant because already called in `util.normpath` itself called in Item class Co-authored-by: Šarūnas Nejus <snejus@protonmail.com>
Nest and combine some logic tests by: 1. Only check for destination file existence once. 2. Use `original` instead of `item.path` in the `refresh` conditional such that this option will be compatible with `keep_new`.
pierreay
force-pushed
the
pr-feat-convert-refresh
branch
from
a454dbc to
fe9365a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default, the
convertplugin will skip every pending conversion if the converted file is already existing on the filesystem. However, when making changes (e.g., tags) in the original files, the changes are not reflected to the converted library. Adding the--refreshcommand-line option and therefreshoption to theconvertplugin allows to re-convert the original files if they are modified more recently than the time when converted files were converted.To Do