Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IMBackend#compare on ImageMagick 7.1.1-44 #5650

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

jackwilsdon
Copy link
Member

@jackwilsdon jackwilsdon commented Feb 27, 2025

Description

ImageMagick 7.1.1-44 now outputs phash result in a different format (as of ImageMagick/ImageMagick@d85a758):

$ magick --version | head -n1
Version: ImageMagick 7.1.1-43 Q16-HDRI x86_64 afd817ca6:20241222 https://imagemagick.org
$ compare -metric PHASH a.jpg b.jpg NULL:
649.922
$ magick --version | head -n1
Version: ImageMagick 7.1.1-44 Q16-HDRI x86_64 f1c26bed0:20250222 https://imagemagick.org
$ compare -metric PHASH a.jpg b.jpg NULL:
4.25933e+07 (649.931)

Fixes #5527.

To Do

  • Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • Tests. (Very much encouraged but not strictly required.)

@jackwilsdon jackwilsdon force-pushed the fix-imbackend-compare branch from e6bf179 to 5c1817c Compare February 27, 2025 01:03
GaetanLepage added a commit to GaetanLepage/nixpkgs that referenced this pull request Feb 27, 2025
GaetanLepage added a commit to GaetanLepage/nixpkgs that referenced this pull request Feb 28, 2025
@doronbehar
Copy link
Contributor

We can confirm this fixes the issue on NixOS, is there any objection for this to getting merged?

@jackwilsdon
Copy link
Member Author

I'm happy to merge this, I've also tested it on NixOS 👍 not sure when the next release is but I guess nixpkgs can pull in this patch for now.

@jackwilsdon jackwilsdon merged commit 1f93867 into beetbox:master Feb 28, 2025
10 checks passed
@jackwilsdon jackwilsdon deleted the fix-imbackend-compare branch February 28, 2025 09:09
@doronbehar
Copy link
Contributor

Thanks :). Merging this gives us confident that the patch link will stay stable and the hash of it stable as well, because the PR's contents don't change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test fails on OpenBSD at 2.2.0: At index 13 diff: b'\x00' != b'\x01'
2 participants