Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import_task_before_choice event for singleton imports #5654

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marksdestiny
Copy link

@marksdestiny marksdestiny commented Mar 3, 2025

Description

This PR fixes a bug which caused the import_task_before_choice event not to be sent for singleton imports.

I suppose this was just an oversight, as this behavior is not mentioned in the documentation.

To Do

  • Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • Tests. (Very much encouraged but not strictly required.)

Fix a bug which caused the import_task_before_choice event not to
be sent for singleton imports.
Copy link

github-actions bot commented Mar 3, 2025

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant