Allow random-1.3 #55
Merged
Allow random-1.3 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement `uniformByteArrayM` in terms of `uniformByteArray`. Fixes byorgey#54.
|
Pinging @lehins. |
|
Wow, that does seem almost too easy. I had been working on upgrading but my code was way more complicated (see haskell/random#179 ). I will take a look, but would also love any insights from @lehins . |
|
Hmm, I looked into this a bit more, and it seems very plausible! I'm glad I didn't work on my overly complex version any more. I don't know why the CI keeps being cancelled. I try re-running it and after a few seconds it says all the checks were cancelled by me. |
|
Your CI is using |
Implement either `uniformByteArrayM` or `uniformShortByteString` depending on the version of `random`, but not both Co-authored-by: Alexey Kuleshevich <lehins@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
uniformByteArrayMin terms ofuniformByteArray. I'll admit, this seems almost too easy to be correct so do let me know if there is something I have missed.Fixes #54.