Implement preopened_dir using set_mapped_directories setting #427
Conversation
There was a problem hiding this comment.
Wasmtime's API for this takes 1 dir at a time -- not a collection of (src, dest). Unless we have a reason to, I'd rather stick to the Rust API shape and naming.
Sticking to the rust crate API been a general rule of thumb for the Ruby bindings. In this case, it makes the API easier to describe. Especially as we eventually migrate to wasmtime_wasi instead of wasi_common which has additional params for permissions.
lib/wasmtime/version.rb
Outdated
| VERSION = "29.0.0" | ||
| VERSION = "30.0.0" |
There was a problem hiding this comment.
Please do not bump the version number
ext/src/ruby_api/wasi_ctx_builder.rs
Outdated
| use magnus::{ | ||
| class, function, gc::Marker, method, typed_data::Obj, value::Opaque, DataTypeFunctions, Error, | ||
| Module, Object, RArray, RHash, RString, Ruby, TryConvert, TypedData, | ||
| Integer, Module, Object, RArray, RHash, RString, Ruby, TryConvert, TypedData, |
There was a problem hiding this comment.
I don't see Integer being used, I think we can revert that?
| @@ -47,6 +49,7 @@ struct WasiCtxBuilderInner { | |||
| stderr: Option<WriteStream>, | |||
| env: Option<Opaque<RHash>>, | |||
| args: Option<Opaque<RArray>>, | |||
| mapped_directories: Option<Opaque<RArray>>, | |||
There was a problem hiding this comment.
When holding references to Ruby objects, we must GC mark them, otherwise the GC might collect the object. See WasiCtxBuilderInner::mark on L56 for how it's done.
Should I just append one by one to the array and then call the |
Sounds reasonable to me. The array should contain Let me know once you're done with the change and the tests. |
… set only one mapping per call
|
I have updated the way how |
|
I can take a look at cleaning it up once the tests are in -- care to add those in? |
No description provided.