Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump wasmtime to v30.0.2 #440

Merged
merged 5 commits into from
Mar 5, 2025
Merged

Bump wasmtime to v30.0.2 #440

merged 5 commits into from
Mar 5, 2025

Conversation

saulecabrera
Copy link
Member

Grabbing the latest patch release since it contains the latest fixes.

This change also mirrors the async_stack_zeroing change, introduced in bytecodealliance/wasmtime#10027

Grabbing the latest patch release since it contains the latest fixes.

This change also mirrors the `async_stack_zeroing` change, introduced in
bytecodealliance/wasmtime#10027
@saulecabrera saulecabrera requested a review from jbourassa March 3, 2025 13:43
Copy link
Collaborator

@jbourassa jbourassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The docs failure may be related to the nightly version we're pinning to. You should be able to use a more recent nightly by also bumping the yard-rustdoc gem (the format changed again but I fixed it a few weeks ago).

@jbourassa
Copy link
Collaborator

jbourassa commented Mar 5, 2025

Not sure why --target-dir stopped working, but you could try with -o. I'd try it myself but won't be around the computer for a while.

@saulecabrera
Copy link
Member Author

Not sure why --target-dir stopped working, but you could try with -o. I'd try it myself but won't be around the computer for a while.

Yeah I tried with -o, but then I get

Unrecognized option p

But I think something else is going on here, when I run the the (existing) command in the terminal, everything works as expected.

To ensure no unwanted new lines or spaces are included as part of
interpolation
@saulecabrera
Copy link
Member Author

For some reason this line

nightly = File.readlines("NIGHTLY_VERSION").first

was introducing a newline, and when interpolated was causing the string to split and therefore the command to be treated erroneously.

@saulecabrera saulecabrera merged commit d87c0e0 into main Mar 5, 2025
16 checks passed
@saulecabrera saulecabrera deleted the wasmtime-30 branch March 5, 2025 15:52
@jbourassa
Copy link
Collaborator

Oh yeah that makes sense, the diff shows the newly added new line at end of file. But stripping it like you did is perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants