-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump wasmtime to v30.0.2 #440
Conversation
Grabbing the latest patch release since it contains the latest fixes. This change also mirrors the `async_stack_zeroing` change, introduced in bytecodealliance/wasmtime#10027
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The docs failure may be related to the nightly version we're pinning to. You should be able to use a more recent nightly by also bumping the yard-rustdoc gem (the format changed again but I fixed it a few weeks ago).
Not sure why --target-dir stopped working, but you could try with -o. I'd try it myself but won't be around the computer for a while. |
Yeah I tried with
But I think something else is going on here, when I run the the (existing) command in the terminal, everything works as expected. |
To ensure no unwanted new lines or spaces are included as part of interpolation
For some reason this line
was introducing a newline, and when interpolated was causing the string to split and therefore the command to be treated erroneously. |
Oh yeah that makes sense, the diff shows the newly added new line at end of file. But stripping it like you did is perfect. |
Grabbing the latest patch release since it contains the latest fixes.
This change also mirrors the
async_stack_zeroing
change, introduced in bytecodealliance/wasmtime#10027