feat(setup-yarn-cache): add new action, from the C8 monorepo #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
kellervater
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Looking great.
Just one question on this:
Do you think it's worth observing this setup-node issue? If they come up with a built-in solution it could make sense.
I subscribed to it now but given the timeline I'm not expecting much soon. |
github-merge-queue bot
pushed a commit
to camunda/camunda
that referenced
this pull request
Sep 5, 2024
## Description Use camunda/infra-global-github-actions#255 from the Infra team (drop-in replacement doing the same) which allows other teams to also benefit from this behavior tailored towards monorepos. ## Checklist <!--- Please delete options that are not relevant. Boxes should be checked by reviewer. --> - [x] for CI changes: - [ ] structural/foundational changes signed off by [CI DRI](https://github.com/cmur2) - [x] [ci.yml](https://github.com/camunda/camunda/blob/main/.github/workflows/ci.yml) modifications comply with ["Unified CI" requirements](https://github.com/camunda/camunda/wiki/CI-&-Automation#workflow-inclusion-criteria) ## Related issues None
github-merge-queue bot
pushed a commit
to camunda/camunda
that referenced
this pull request
Sep 5, 2024
## Description Use camunda/infra-global-github-actions#255 from the Infra team (drop-in replacement doing the same) which allows other teams to also benefit from this behavior tailored towards monorepos. ## Checklist <!--- Please delete options that are not relevant. Boxes should be checked by reviewer. --> - [x] for CI changes: - [ ] structural/foundational changes signed off by [CI DRI](https://github.com/cmur2) - [x] [ci.yml](https://github.com/camunda/camunda/blob/main/.github/workflows/ci.yml) modifications comply with ["Unified CI" requirements](https://github.com/camunda/camunda/wiki/CI-&-Automation#workflow-inclusion-criteria) ## Related issues None
github-merge-queue bot
pushed a commit
to camunda/camunda
that referenced
this pull request
Sep 5, 2024
## Description Use camunda/infra-global-github-actions#255 from the Infra team (drop-in replacement doing the same) which allows other teams to also benefit from this behavior tailored towards monorepos. ## Checklist <!--- Please delete options that are not relevant. Boxes should be checked by reviewer. --> - [x] for CI changes: - [ ] structural/foundational changes signed off by [CI DRI](https://github.com/cmur2) - [x] [ci.yml](https://github.com/camunda/camunda/blob/main/.github/workflows/ci.yml) modifications comply with ["Unified CI" requirements](https://github.com/camunda/camunda/wiki/CI-&-Automation#workflow-inclusion-criteria) ## Related issues None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This action was originally created in camunda/camunda#21427 but is now relocated for wider use also in other repositories (disccused in Slack).
Noteworthy is the new input for this action
cache_create_branch_regexwhich allows configuring on which branches to save the cache on (done via Bash now instead of GHA expression to allow parameterization), the defaults suit the C8 monorepo to avoid repeating configuration.The new action is successfully used in https://github.com/camunda/camunda/actions/runs/10699692498/job/29661839825?pr=21915 as an example