Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): close menu on Tab key press #3311

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pablopupo
Copy link

When pressing Tab in the menu, the menu remained open, which is not expected behavior for keyboard navigation according to WAI ARIA Authoring Practices Guide for Menu and Menubar Pattern. This was an issue that was reported in Issue 9608 of chakra-ui/chakra-ui but needed to be fixed upstream.

I fixed this by adding an onKeyDown handler in menu-content.tsx that calls menu.setOpen(false) when event.key === 'Tab'

Copy link

vercel bot commented Feb 18, 2025

@pablopupo is attempting to deploy a commit to the Chakra UI Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant