Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nathanfishcircleci patch 2 #9237

Merged
merged 10 commits into from
Feb 25, 2025
Merged

Nathanfishcircleci patch 2 #9237

merged 10 commits into from
Feb 25, 2025

Conversation

nathanfishcircleci
Copy link
Contributor

Description

A brief description of the changes.

Reasons

A link to a GitHub and/or JIRA issue (if applicable).
Otherwise, a brief sentence about why you made these changes.

Content Checklist

Please follow our style when contributing to CircleCI docs. Our style guide is here: https://circleci.com/docs/style/style-guide-overview.

Please take a moment to check through the following items when submitting your PR (this is just a guide so will not be relevant for all PRs) 😸:

  • Break up walls of text by adding paragraph breaks.
  • Consider if the content could benefit from more structure, such as lists or tables, to make it easier to consume.
  • Keep the title between 20 and 70 characters.
  • Consider whether the content would benefit from more subsections (h2-h6 headings) to make it easier to consume.
  • Check all headings h1-h6 are in sentence case (only first letter is capitalized).
  • Is there a "Next steps" section at the end of the page giving the reader a clear path to what to read next?
  • Include relevant backlinks to other CircleCI docs/pages.

add some specifics about status updates (supported by all vcs integrations). Need to add a callout for disabling status updates automatically when enabling github checks.
@nathanfishcircleci nathanfishcircleci requested review from a team as code owners February 19, 2025 17:05
@nathanfishcircleci
Copy link
Contributor Author

Some updates to clarify status updates handling and where you can disable or enable status updates.

| [.circle-green]#**Yes**#
| [.circle-green]#**Yes**#
| [.circle-green]#**Yes**#
| [.circle-green]#**Yes**# ^4^
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking... [.circle-green]#**Yes** ^4^#, so the "4" has the same color as the "Yes"

@@ -84,7 +84,16 @@ include::../_includes/partials/tips/check-github-type.adoc[Check your GitHub int
| [.circle-green]#**Yes**#
| [.circle-red]#**No** ^1^#

| xref:enable-checks#[GitHub Checks]
| xref:enable-checks#github-check-and-github-status-updates[Status Updates]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this link as we do not yet have a guide to "status updates"

@rosieyohannan rosieyohannan merged commit fe26c29 into master Feb 25, 2025
3 checks passed
@rosieyohannan rosieyohannan deleted the nathanfishcircleci-patch-2 branch February 25, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants