-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nathanfishcircleci patch 2 #9237
Conversation
add some specifics about status updates (supported by all vcs integrations). Need to add a callout for disabling status updates automatically when enabling github checks.
Some updates to clarify status updates handling and where you can disable or enable status updates. |
| [.circle-green]#**Yes**# | ||
| [.circle-green]#**Yes**# | ||
| [.circle-green]#**Yes**# | ||
| [.circle-green]#**Yes**# ^4^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicking... [.circle-green]#**Yes** ^4^#
, so the "4" has the same color as the "Yes"
@@ -84,7 +84,16 @@ include::../_includes/partials/tips/check-github-type.adoc[Check your GitHub int | |||
| [.circle-green]#**Yes**# | |||
| [.circle-red]#**No** ^1^# | |||
|
|||
| xref:enable-checks#[GitHub Checks] | |||
| xref:enable-checks#github-check-and-github-status-updates[Status Updates] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this link as we do not yet have a guide to "status updates"
Description
A brief description of the changes.
Reasons
A link to a GitHub and/or JIRA issue (if applicable).
Otherwise, a brief sentence about why you made these changes.
Content Checklist
Please follow our style when contributing to CircleCI docs. Our style guide is here: https://circleci.com/docs/style/style-guide-overview.
Please take a moment to check through the following items when submitting your PR (this is just a guide so will not be relevant for all PRs) 😸: