docker login; docker push fails
#2
Comments
|
Yeah - the containers by default run old Docker - we plan to update our containers with the latest Docker. For the time-being, can you try using the following commands to upgrade Docker (also please remove docker from Let me know how it goes! |
|
Yeah, I've got that version running in my Circle CI instances using the below |
|
Can you remove We are working on supporting Docker 1.7 - should be coming relatively soon. |
|
I'm getting the same problem even after removing docker from |
|
I have reproduced the process with 1.6.2 here: https://circleci.com/gh/circleci/docker-elasticsearch/55 based on [1]. May I suggest reaching CircleCI support - our support engineers can dig into your build better and debug the issue. |
TL;DR: check for IsExist(err) after a failed MkdirAll() is both
redundant and wrong -- so two reasons to remove it.
Quoting MkdirAll documentation:
> MkdirAll creates a directory named path, along with any necessary
> parents, and returns nil, or else returns an error. If path
> is already a directory, MkdirAll does nothing and returns nil.
This means two things:
1. If a directory to be created already exists, no error is returned.
2. If the error returned is IsExist (EEXIST), it means there exists
a non-directory with the same name as MkdirAll need to use for
directory. Example: we want to MkdirAll("a/b"), but file "a"
(or "a/b") already exists, so MkdirAll fails.
The above is a theory, based on quoted documentation and my UNIX
knowledge.
3. In practice, though, current MkdirAll implementation [1] returns
ENOTDIR in most of cases described in #2, with the exception when
there is a race between MkdirAll and someone else creating the
last component of MkdirAll argument as a file. In this very case
MkdirAll() will indeed return EEXIST.
Because of #1, IsExist check after MkdirAll is not needed.
Because of #2 and #3, ignoring IsExist error is just plain wrong,
as directory we require is not created. It's cleaner to report
the error now.
Note this error is all over the tree, I guess due to copy-paste,
or trying to follow the same usage pattern as for Mkdir(),
or some not quite correct examples on the Internet.
[v2: a separate aufs commit is merged into this one]
[1] https://github.com/golang/go/blob/f9ed2f75/src/os/path.go
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Fix exec start api with detach and AttachStdin at same time. fixes #2…
[20.10] Lock down docker root dir perms.
Even after logging in, the docker push command tries to get authentication details interactively. Passing the details as a heredoc fails with a docker error about invalid ioctl. I believe this may be related to a breaking change in the docker hub auth API in version 1.7. Where does Circle CI stand on installing an updated docker version? My attempts to script it in my circle.yml have failed miserably...
The text was updated successfully, but these errors were encountered: