fix(dates): Tries to parse string dates in collection

Author: pixelastic

lib/jekyll/algolia/file_browser.rb

@@ -2,6 +2,7 @@
 
 require 'algolia_html_extractor'
 require 'pathname'
+require 'time'
 
 module Jekyll
   module Algolia
@@ -234,14 +235,24 @@ def self.categories(file)
       def self.date(file)
         # Collections get their date from .date, while pages read it from .data.
         # Jekyll by default will set the date of collection to the current date,
-        # but we overwrote this.
+        # but we monkey-patched that so it returns nil for collection items
         date = if file.respond_to?(:date)
                  file.date
                else
                  file.data['date']
                end
 
         return nil if date.nil?
+
+        # If date is a string, we try to parse it
+        if date.is_a? String
+          begin
+            date = Time.parse(date)
+          rescue StandardError
+            return nil
+          end
+        end
+
         date.to_time.to_i
       end
 

spec/jekyll/algolia/file_browser_spec.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
+# rubocop:disable Metrics/BlockLength
 require 'spec_helper'
 
-# rubocop:disable Metrics/BlockLength
 describe(Jekyll::Algolia::FileBrowser) do
   let(:current) { Jekyll::Algolia::FileBrowser }
   let(:configurator) { Jekyll::Algolia::Configurator }
@@ -520,11 +520,33 @@
         let(:filepath) { 'sample-item.md' }
         it { should eq nil }
       end
-      describe 'date in frontmatter' do
+      describe 'date in frontmatter as DD-MM-YYYY' do
         let(:filepath) { 'collection-item.md' }
         it { should eq 452_469_600 }
       end
     end
+
+    # Sometimes a conjunction of plugins on the user side can change the format
+    # of the date (it should be passed as a date object) and keep it as
+    # a string. In order to test those cases, we will manually pass strings to
+    # the call
+    context 'direct call' do
+      subject { current.date(file) }
+
+      let(:file) { double('File') }
+      before do
+        allow(file).to receive(:data).and_return(mock_data)
+      end
+
+      describe 'date as a valid string' do
+        let(:mock_data) { { 'date' => '1984-05-04' } }
+        it { should eq 452_469_600 }
+      end
+      describe 'date as a invalid string' do
+        let(:mock_data) { { 'date' => 'azertyuiop' } }
+        it { should eq nil }
+      end
+    end
   end
 
   describe '.excerpt_raw' do