Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: limit items per minute #42

Open
firthh opened this issue Aug 5, 2019 · 1 comment
Open

Feature request: limit items per minute #42

firthh opened this issue Aug 5, 2019 · 1 comment

Comments

@firthh
Copy link

firthh commented Aug 5, 2019

The official NodeJS Rollbar client supports itemsPerMinute as configuration (https://docs.rollbar.com/docs/rollbarjs-configuration-reference#section-global). It would be nice if this supported something similar.

I realise this might make the library a bit more stateful but it could be beneficial for when things go catastrophically wrong like infinite loops.

@marcomorain
Copy link
Contributor

Hi Hugo,

Thanks for logging the issue.

We usually do this at CircleCI by putting a rate limit on the token itself in the Rollbar UI. This allows us to set a max number of items that can be reported at a time, but it’s handled server side.

Would that solve your use-case?

Another neat way to do this simply would be to wrap the reporting function with a throttled version of the function. Do you know any neat libraries that add throttling to a var? I’ve done this with underscore.js I’m the past I’m JavaScript. I don’t know of any Clojure libraries that do the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants