[ONPREM-1958] Bump Go to 1.24 and move to go tool #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
christian-stephen
force-pushed
the
cs/tool
branch
4 times, most recently
from
28efb4d to
ce663a6
Compare
christian-stephen
force-pushed
the
cs/tool
branch
from
ce663a6 to
772cd0d
Compare
| - when: | ||
| condition: | ||
| equal: [ << pipeline.parameters.triggered_by_webhook >>, true ] | ||
| - with-go-cache: |
There was a problem hiding this comment.
Since we get GoReleaser and Cosign through go tool now, let's cache them
Comment on lines
+59
to
+60
| - cmd: go | ||
| args: ["tool", "cosign", "sign", "--key=cosign.key", "${artifact}@${digest}", "--yes"] |
There was a problem hiding this comment.
Bit unfortunate, but we apparently can't template here for cmd: https://goreleaser.com/customization/docker_sign/
(Ideally, I would've like to do something along the lines of this: 28efb4d#diff-ac0b52a2ae6ef99999bc08fb31e19188bf0085a4614204068e677e140e1458be)
There was a problem hiding this comment.
This does seem pretty readable at least
ryanwohara
approved these changes
Feb 19, 2025
christian-stephen
force-pushed
the
cs/tool
branch
2 times, most recently
from
16c44d6 to
772cd0d
Compare
jrahme-cci
approved these changes
Feb 19, 2025
christian-stephen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚙️ Issue
⚙️ Change Description
Acceptance Criteria:
✅ Solution
❓ Testing
📖 Documentation Updates