[ONPREM-1972] Don't re-handle task errors #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-stephen
force-pushed
the
ONPREM-1972/handle-errors
branch
2 times, most recently
from
dfdb462 to
ace4a71
Compare
christian-stephen
changed the title
| @@ -226,9 +230,10 @@ func (o *Orchestrator) handleErrors(ctx context.Context, err error) error { | |||
| failErr := o.runnerClient.FailTask(ctx, time.Now(), c.Allocation, err.Error()) | |||
| if failErr != nil { | |||
| failErr = fmt.Errorf("failed to send fail event for task: %w", failErr) | |||
| return errors.Join(failErr, unclaimErr, err) | |||
There was a problem hiding this comment.
If GOAT fails to infra-fail the task, then let container-agent handle it
If GOAT handles a task error (either with an infra-fail or retry), don't exit with a nonzero status code. Doing so causes container agent to overwrite the original error message in the UI.
christian-stephen
force-pushed
the
ONPREM-1972/handle-errors
branch
from
ace4a71 to
8891b87
Compare
| ctx := o.taskContext(parentCtx) | ||
| o.reaper.Enable(ctx) | ||
|
|
||
| defer func() { | ||
| err = o.shutdown(ctx, err) | ||
| o11y.End(span, &err) |
There was a problem hiding this comment.
The original error will always get set on the span, so if GOAT fails to infra-fail or retry the task, then we can still see the error in the logs
jrahme-cci
approved these changes
Feb 24, 2025
ryanwohara
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't re-handle task errors. If GOAT handles a task error (either with an infra-fail or retry), don't exit with a nonzero status code. Doing so causes container agent to overwrite the original error message in the UI.
⚙️ Issue
https://circleci.atlassian.net/browse/ONPREM-1972
⚙️ Change Description
Acceptance Criteria:
✅ Solution
❓ Testing
Before: https://app.circleci.com/pipelines/github/circleci/runner-dummy/3032/workflows/2756dd1b-3af4-4305-b7d2-0effbd68b000/jobs/193765
After: https://app.circleci.com/pipelines/github/circleci/runner-dummy/3032/workflows/23a63cf9-4ee1-4a53-b6d3-c41d9ff7b5b6/jobs/193764
📖 Documentation Updates