We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I see u create PR, however i continue mind and detect case:
For ctx have func WithDataConverter() and this func not set filds in ChildWorkflowOptions - this struct not have field for it
WithDataConverter()
ChildWorkflowOptions
Question: can we assume that DataConverter - option, and implement method WithDataConverter fot exlude using ctx func at all ?
DataConverter
WithDataConverter
example:
ctx = ctx.WithDataConverter(ctx, converter) opts = examplev1.NewExampleV1WorkflowOptions().WithChildOptions(options) examplev1.NewExampleV1(ctx, &examplev1.ExampleV1Request{}, opts)
->
if we assume that DataConverter - option:
opts = examplev1.NewExampleV1WorkflowOptions().WithChildOptions(options).WithDataConverter(conveter) examplev1.NewExampleV1(ctx, &examplev1.ExampleV1Request{}, opts) // in generated code: type ExampleV1ChildOptions struct { opts *workflow.ChildWorkflowOptions // ... dataConverter *converter.DataConverter } func ExampleV1Child(ctx workflow.Context, req *ExampleV1Request, options ...*ExampleV1ChildOptions) (*ExampleV1ChildRun, error) { opts := &workflow.ChildWorkflowOptions{} if len(options) > 0 && options[0].opts != nil { opts = options[0].opts } if opts.TaskQueue == "" { opts.TaskQueue = XnsTaskQueue } // ... ctx = workflow.WithChildOptions(ctx, *opts) if c := options[0].dataConverter; c != nil { ctx = workflow.WithDataConverter(ctx, *c) } // ... }
Originally posted by @SeJIya in #58 (comment)
The text was updated successfully, but these errors were encountered:
No branches or pull requests
For ctx have func
WithDataConverter()
and this func not set filds inChildWorkflowOptions
- this struct not have field for itQuestion: can we assume that
DataConverter
- option, and implement methodWithDataConverter
fot exlude using ctx func at all ?example:
->
if we assume that
DataConverter
- option:Originally posted by @SeJIya in #58 (comment)
The text was updated successfully, but these errors were encountered: