-
-
Notifications
You must be signed in to change notification settings - Fork 643
Issue2795: Add shortcut setting and handler for "Activate Fit to window" feature #2835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue2795: Add shortcut setting and handler for "Activate Fit to window" feature #2835
Conversation
hi @RonnyFenrich yay! :) It is requiring to have the button enabled. Some users enabling the shortcut won't know about it, so to consider them, you could make the shortcut only trigger the function, or enable and disable the button too each time, if the button was not already enabled in our menu at the time of setting the shortcut. We also have the same feature at appearance : player : player size: max. height* and other options like max. width, which you might like ( #2794 (comment) ) Generally we can also make shortcuts change one of the toggles in our menu too, by changing chromium storage variables. youtube/js&css/web-accessible/www.youtube.com/shortcuts.js Lines 460 to 467 in 75bfa7e
youtube/js&css/web-accessible/core.js Lines 207 to 213 in 75bfa7e
*So the player button "fit to window" actually is "max height" and the icon's arrow will more accurately be vertical, instead of should not be diagonal. And this project should be about keeping all these things consistent ( deduplicated ) |
Interesting! I didn't know this exists. This should take care of my other feature wish where I wanted my player to always show the fullscreen/fit to window view by default. Great! |
…new shortcut handler
…r shortcutActivateFitToWindow
@ImprovedTube Here are the changes:
|
This PR implements my own feature request :)
It allows the user to define a shortcut which will toggle the "Fit to window" player functionality.