Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust support to custom config #4

Closed
filipesperandio opened this issue Sep 12, 2017 · 0 comments
Closed

Adjust support to custom config #4

filipesperandio opened this issue Sep 12, 2017 · 0 comments
Assignees
@filipesperandio

Comments

@filipesperandio
Copy link
Contributor

filipesperandio commented Sep 12, 2017 •
edited
Loading

  • The expected config attribute on .codeclimate.yml should follow the same pattern as other engines.
  • Should accept a hash:
config:
  file: rules.xml
  • Should be backward compatible:
config: rules.xml
@filipesperandio filipesperandio self-assigned this Sep 12, 2017
filipesperandio added a commit that referenced this issue Sep 12, 2017
@filipesperandio
Support new config format. Fix #4
f93deb0
filipesperandio added a commit that referenced this issue Sep 14, 2017
@filipesperandio
Support config.file from yml (#8)
b266ba8 
* Fix #4

* Abort execution on bad config

* Supports old and new formats and fallback to default config if none is specified:
```yml
config: rules.xml
```

```yml
config:
  file: rules.xml
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filipesperandio filipesperandio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@filipesperandio