Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: codeclimate/ruby-test-reporter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: codeclimate/ruby-test-reporter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: mj-pass-thru-travis-sha
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Nov 14, 2016

  1. Pass thru Travis PR SHA 

    When Travis builds a PR, as opposed to a push, it checks out the merge
commit that GitHub exposes and runs the tests at that SHA.

When we report the results, however, we'd like to report them for the
HEAD SHA from the PR, because otherwise the status won't show up.

it's possible the coverage results will differ slightly between the
merge SHA and the HEAD sha, but I'm not sure if anyone will be offended
by this fiction. We've had one report that a user is surprised not to
receive a status check when they only have Pull Request builds enabled,
and not Push builds.
    @maxjacobson
    maxjacobson committed Nov 14, 2016
    Copy the full SHA
    b4a7469 View commit details

Commits on Nov 15, 2016

  1. also send the branch from the pull request

    @maxjacobson
    maxjacobson committed Nov 15, 2016
    Copy the full SHA
    edc4ccb View commit details
Loading