Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep release #165

Merged
merged 2 commits into from
Dec 29, 2016
Merged

Prep release #165

merged 2 commits into from
Dec 29, 2016

Conversation

maxjacobson
Copy link
Contributor

No description provided.

@@ -4,10 +4,22 @@

### New features

### Bug fixes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these intentionally left empty?

Copy link
Contributor Author

@maxjacobson maxjacobson Dec 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, the thinking is that it will encourage people to put their changelog entries into one of our expected buckets when they make a contribution. This format is generally inspired by rubocop's changelog, and I guess I thought they did that, but maybe not actually

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. LGTM!

@maxjacobson
Copy link
Contributor Author

Just doing some additional QA before shipping. Decided I want to actually see it merge some result sets first :)

@maxjacobson
Copy link
Contributor Author

https://circleci.com/gh/codeclimate/api/866

Using the default profile...
0 scenarios
0 steps
0m0.000s
Coverage report generated for Cucumber Features to /app/coverage. 258 / 373 LOC (69.17%) covered.
............................................................................................................................

Finished in 2.71 seconds (files took 2.21 seconds to load)
124 examples, 0 failures

Coverage report generated for Cucumber Features, RSpec to /app/coverage. 1097 / 1156 LOC (94.9%) covered.
I, [2016-12-29T18:02:19.324117 #26]  INFO -- : Reporting coverage data to Code Climate.
Sending report to https://codeclimate.com for branch mj/ruby-test-reporter-upgrade-test... done.

LGTM :)

@maxjacobson maxjacobson merged commit 651e903 into master Dec 29, 2016
@maxjacobson maxjacobson deleted the mj/prep-release branch December 29, 2016 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants